Rollup of 10 pull requests #132756

workingjubilee · 2024-11-08T02:48:27Z

Successful merges:

Set "symbol name" in raw-dylib import libraries to the decorated name #130586 (Set "symbol name" in raw-dylib import libraries to the decorated name)
Add {ignore,needs}-{rustc,std}-debug-assertions directive support #131913 (Add {ignore,needs}-{rustc,std}-debug-assertions directive support)
Fix #131977 parens mangled in shared mut static lint suggestion #132095 (Fix Missing parenthesis in static_mut_refs diagnostic suggestion #131977 parens mangled in shared mut static lint suggestion)
[StableMIR] API to retrieve definitions from crates #132131 ([StableMIR] API to retrieve definitions from crates)
core: move intrinsics.rs into intrinsics folder #132639 (core: move intrinsics.rs into intrinsics folder)
Compile test_num_f128 conditionally on reliable_f128_math config #132696 (Compile test_num_f128 conditionally on reliable_f128_math config)
bootstrap: Print better message if lock pid isn't available #132737 (bootstrap: Print better message if lock pid isn't available)
Fix librustdoc/scrape_examples.rs formatting #132739 (Fix librustdoc/scrape_examples.rs formatting)
Update test for LLVM 20's new vector splat syntax #132740 (Update test for LLVM 20's new vector splat syntax)
Update mips64 data layout to match LLVM 20 change #132741 (Update mips64 data layout to match LLVM 20 change)

r? @ghost
@rustbot modify labels: rollup

…ive support And retire the old `only-debug` directive which was ambiguous and only for std debug assertions.

And rename local variables and field names in bootstrap from `debug_assertions{,_std}` -> `{rustc,std}-debug-assertions` to avoid confusion where applicable.

that was introduced in llvm/llvm-project#112548

LLVM changed the data layout in llvm/llvm-project#112084

Add functions to retrieve function definitions and static items from all crates (local and external). For external crates, add a query to retrieve the number of defs in a foreign crate.

Set "symbol name" in raw-dylib import libraries to the decorated name `windows-rs` received a bug report that mixing raw-dylib generated and the Windows SDK import libraries was causing linker failures: <microsoft/windows-rs#3285> The root cause turned out to be rust-lang#124958, that is we are not including the decorated name in the import library and so the import name type is also not being correctly set. This change modifies the generation of import libraries to set the "symbol name" to the fully decorated name and correctly marks the import as being data vs function. Note that this also required some changes to how the symbol is named within Rust: for MSVC we now need to use the decorated name but for MinGW we still need to use partially decorated (or undecorated) name. Fixes rust-lang#124958 Passing i686 MSVC and MinGW build: <https://github.com/rust-lang/rust/actions/runs/11000433888?pr=130586> r? `@ChrisDenton`

…onur-ozkan Add `{ignore,needs}-{rustc,std}-debug-assertions` directive support Add `{ignore,needs}-{rustc,std}-debug-assertions` compiletest directives and retire the old `{ignore,only}-debug` directives. The old `{ignore,only}-debug` directives were ambiguous because you could have std built with debug assertions but rustc not built with debug assertions or vice versa. If we want to support the use case of controlling test run based on if rustc was built with debug assertions, then having `{ignore,only}-debug` will be very confusing. cc ````@matthiaskrgr```` Closes rust-lang#123987. r? bootstrap (or compiler tbh)

…iser Fix rust-lang#131977 parens mangled in shared mut static lint suggestion Resolves rust-lang#131977 for static mut references after discussion with Esteban & Jieyou on [t-compiler/help](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/linting.20with.20parens.20in.20the.20HIR). This doesn't do anything to change the underlying issue if there are other expressions that generate lint suggestions which need to be applied within parentheses.

…er-errors [StableMIR] API to retrieve definitions from crates Add functions to retrieve function definitions and static items from all crates (local and external). For external crates, we're still missing items from trait implementation and primitives. r? ````@compiler-errors:```` Do you know what is the best way to retrieve the associated items for primitives and trait implementations for external crates? Thanks!

…lee,Amanieu core: move intrinsics.rs into intrinsics folder This makes the rustbot notification we have set up for this folder in `triagebot.toml` actually work. Also IMO it makes more sense to have it all in one folder.

…issing_symbol_issue, r=tgross35 Compile `test_num_f128` conditionally on `reliable_f128_math` config With rust-lang#132434 merged, our internal SGX CI started failing with: ``` 05:27:34 = note: rust-lld: error: undefined symbol: fmodl 05:27:34 >>> referenced by arith.rs:617 (core/src/ops/arith.rs:617) 05:27:34 >>> /home/jenkins/workspace/rust-sgx-ci/rust/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-fortanix-unknown-sgx/release/deps/std-5d5f11eb008c9091.std.d8141acc61ab7ac8-cgu.10.rcgu.o:(std::num::test_num::h7dd9449f6c01fde8) 05:27:34 >>> did you mean: fmodf 05:27:34 >>> defined in: /home/jenkins/workspace/rust-sgx-ci/rust/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-fortanix-unknown-sgx/release/deps/libcompiler_builtins-0376f439a2ebf305.rlib(compiler_builtins-0376f439a2ebf305.compiler_builtins.c22db39d25d6f802-cgu.148.rcgu.o) ``` This originated from the `test_num_f128` test not having the required conditional compilation. This PR fixes that issue. cc: ````@jethrogb,```` ````@workingjubilee````

bootstrap: Print better message if lock pid isn't available Not actually sure why, but sometimes the PID isn't available so we print ``` WARNING: build directory locked by process , waiting for lock ``` This makes the message a bit nicer in this case

…, r=notriddle Fix `librustdoc/scrape_examples.rs` formatting Still working on the intra-doc link feature. This time I encountered this file and it bothered me a bit so fixing formatting. :3 r? ````@notriddle````

Update test for LLVM 20's new vector splat syntax that was introduced in llvm/llvm-project#112548

Update mips64 data layout to match LLVM 20 change LLVM changed the data layout in llvm/llvm-project#112084

workingjubilee · 2024-11-08T02:48:48Z

@bors r+ rollup=never p=5

bors · 2024-11-08T02:48:51Z

📌 Commit 97dbab9 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-11-08T03:32:55Z

⌛ Testing commit 97dbab9 with merge 78bb5ee...

bors · 2024-11-08T06:53:02Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 78bb5ee to master...

rust-timer · 2024-11-08T06:55:55Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#130586	Set "symbol name" in raw-dylib import libraries to the deco…	`a52b431f7b1f0d08b73d357e7a4eeb44f143d854` (link)
#131913	Add `{ignore,needs}-{rustc,std}-debug-assertions` directive…	`9b9396928276f8efd74fd6696e80d5cad138d2b5` (link)
#132095	Fix #131977 parens mangled in shared mut static lint sugges…	`7ae701d136c2a888a467a6ef1c4575e3f92c5d64` (link)
#132131	[StableMIR] API to retrieve definitions from crates	`948413cdf946a662b687d5cf7cede4c1189f5ff9` (link)
#132639	core: move intrinsics.rs into intrinsics folder	`d20649464aedbef66a75a4b3bb13870838f3a5d0` (link)
#132696	Compile `test_num_f128` conditionally on `reliable_f128_mat…	`61e71dfabef7c7295668706c52af5d558d9ea8da` (link)
#132737	bootstrap: Print better message if lock pid isn't available	`64cf09cc502b43d04a81146d6b6a73d731c3696f` (link)
#132739	Fix `librustdoc/scrape_examples.rs` formatting	`347c6aa993c948f9a0ce8978561d23b66e721c46` (link)
#132740	Update test for LLVM 20's new vector splat syntax	`ac07d647b23cb52614f0f8cb5a985fee35dc7af7` (link)
#132741	Update mips64 data layout to match LLVM 20 change	`8bdaeb8e20e188423a985c3b8e90d9176077285f` (link)

previous master: 5b20c45999

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-11-08T08:11:07Z

Finished benchmarking commit (78bb5ee): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-0.9%	[-1.1%, -0.7%]	2
All ❌✅ (primary)	-1.4%	[-1.4%, -1.4%]	1

Max RSS (memory usage)

Results (primary 0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.5%, 2.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[-2.1%, 2.2%]	3

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	23
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	23

Bootstrap: 781.382s -> 780.076s (-0.17%)
Artifact size: 335.34 MiB -> 335.37 MiB (0.01%)

…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#130586 (Set "symbol name" in raw-dylib import libraries to the decorated name) - rust-lang#131913 (Add `{ignore,needs}-{rustc,std}-debug-assertions` directive support) - rust-lang#132095 (Fix rust-lang#131977 parens mangled in shared mut static lint suggestion) - rust-lang#132131 ([StableMIR] API to retrieve definitions from crates) - rust-lang#132639 (core: move intrinsics.rs into intrinsics folder) - rust-lang#132696 (Compile `test_num_f128` conditionally on `reliable_f128_math` config) - rust-lang#132737 (bootstrap: Print better message if lock pid isn't available) - rust-lang#132739 (Fix `librustdoc/scrape_examples.rs` formatting) - rust-lang#132740 (Update test for LLVM 20's new vector splat syntax) - rust-lang#132741 (Update mips64 data layout to match LLVM 20 change) r? `@ghost` `@rustbot` modify labels: rollup

dpaoliello and others added 23 commits September 24, 2024 10:10

Test fixing raw-dylib

b2fd8a0

Fix rust-lang#131977 parens mangled in shared mut static lint suggestion

cc0ec04

compiletest: add {ignore,needs}-{rustc,std}-debug-assertions direct…

65b986b

…ive support And retire the old `only-debug` directive which was ambiguous and only for std debug assertions.

bootstrap: pass --with-{rustc,std}-debug-assertions to compiletest

3870022

And rename local variables and field names in bootstrap from `debug_assertions{,_std}` -> `{rustc,std}-debug-assertions` to avoid confusion where applicable.

tests: ignore-debug -> ignore-std-debug-assertions

0d5cc8e

Separate f128 % operation to deal with missing fmodl symbol

0720880

Fix file formatting

9f5e17f

core: move intrinsics.rs into intrinsics folder

ab1787b

bootstrap: Print better message if lock pid isn't available

1ee5ab3

Update test for LLVM 20's new vector splat syntax

0e58f1c

that was introduced in llvm/llvm-project#112548

Update mips64 data layout to match LLVM 20 change

392ac35

LLVM changed the data layout in llvm/llvm-project#112084

remove the extra specification for llvm versions < 20

eb7d95b

[StableMIR] API to retrieve definitions from crates

0ce579f

Add functions to retrieve function definitions and static items from all crates (local and external). For external crates, add a query to retrieve the number of defs in a foreign crate.

Rollup merge of rust-lang#132740 - zmodem:simd_syntax_update, r=durin42

e2d429e

Update test for LLVM 20's new vector splat syntax that was introduced in llvm/llvm-project#112548

Rollup merge of rust-lang#132741 - zmodem:mips_data_layout, r=nikic

97dbab9

Update mips64 data layout to match LLVM 20 change LLVM changed the data layout in llvm/llvm-project#112084

rustbot added the rollup A PR which is a rollup label Nov 8, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 8, 2024

bors merged commit 78bb5ee into rust-lang:master Nov 8, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Nov 8, 2024

bors mentioned this pull request Nov 8, 2024

Likely unlikely fix #120370

Merged

workingjubilee deleted the rollup-bed2akn branch November 8, 2024 07:27

This was referenced Nov 8, 2024

mark is_val_statically_known intrinsic as stably const-callable #132449

Merged

tweak attributes for const panic macro #132662

Merged

remove support for rustc_safe_intrinsic attribute; use rustc_intrinsic functions instead #132717

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #132756

Rollup of 10 pull requests #132756

workingjubilee commented Nov 8, 2024

workingjubilee commented Nov 8, 2024

bors commented Nov 8, 2024

bors commented Nov 8, 2024

bors commented Nov 8, 2024

rust-timer commented Nov 8, 2024

rust-timer commented Nov 8, 2024

Rollup of 10 pull requests #132756

Rollup of 10 pull requests #132756

Conversation

workingjubilee commented Nov 8, 2024

workingjubilee commented Nov 8, 2024

bors commented Nov 8, 2024

bors commented Nov 8, 2024

bors commented Nov 8, 2024

rust-timer commented Nov 8, 2024

rust-timer commented Nov 8, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size