rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect #133142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval Some changes occurred to the CTFE machinery cc @rust-lang/wg-const-eval |
rustbot
added
S-waiting-on-review
|
I think this is clearer, but I'll give errs some time to chime in. |
compiler-errors
approved these changes
Nov 17, 2024
|
Ya this is fine. r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #120370) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
r=me when rebased |
RalfJung
force-pushed
the
naming-is-hard
branch
from
e6c0268 to
9d4b1b2
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 18, 2024
…r-errors rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect In rust-lang#120370 this name caused confusion as the author thought the intrinsic was stable. So let's try a different name... If we can land this before the beta cutoff we can avoid needing `cfg(bootstrap)` for this. ;) Cc ``@compiler-errors`` ``@saethlin``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#132934 (Overhaul the `-l` option parser (for linking to native libs)) - rust-lang#133142 (rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect) - rust-lang#133145 (Document alternatives to `static mut`) - rust-lang#133158 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#132934 (Overhaul the `-l` option parser (for linking to native libs)) - rust-lang#133142 (rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect) - rust-lang#133145 (Document alternatives to `static mut`) - rust-lang#133158 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 18, 2024
Rollup merge of rust-lang#133142 - RalfJung:naming-is-hard, r=compiler-errors rename rustc_const_stable_intrinsic -> rustc_intrinsic_const_stable_indirect In rust-lang#120370 this name caused confusion as the author thought the intrinsic was stable. So let's try a different name... If we can land this before the beta cutoff we can avoid needing `cfg(bootstrap)` for this. ;) Cc `@compiler-errors` `@saethlin`
RalfJung
added a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #120370 this name caused confusion as the author thought the intrinsic was stable. So let's try a different name...
If we can land this before the beta cutoff we can avoid needing
cfg(bootstrap)for this. ;)Cc @compiler-errors @saethlin