Make `compare_impl_item` into a query #133365

compiler-errors · 2024-11-23T04:52:12Z

Turns compare_impl_item into a query (generalizing the existing query for compare_impl_const), and uses that in Instance::resolve to fail resolution when an implementation is incompatible with the trait it comes from.

Fixes #119701
Fixes #121127
Fixes #121411
Fixes #129075
Fixes #129127
Fixes #129214
Fixes #131294

compiler-errors · 2024-11-23T04:52:28Z

@bors try @rust-timer queue

bors · 2024-11-23T04:53:38Z

⌛ Trying commit c7ca253 with merge 507b0fd...

…=<try> Make `compare_impl_item` into a query First want to perf, then I'll write something up. r? `@ghost`

bors · 2024-11-23T06:40:49Z

☀️ Try build successful - checks-actions
Build commit: 507b0fd (507b0fdc53b493f2fe2f88a18d7b1f00914beafe)

rust-timer · 2024-11-23T08:30:03Z

Finished benchmarking commit (507b0fd): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	37
Regressions ❌ (secondary)	0.4%	[0.2%, 0.5%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	37

Max RSS (memory usage)

Results (primary -0.9%, secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-1.9%	[-2.6%, -1.4%]	3
Improvements ✅ (secondary)	-1.7%	[-1.7%, -1.7%]	1
All ❌✅ (primary)	-0.9%	[-2.6%, 2.0%]	4

Cycles

Results (primary -2.2%, secondary 9.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	9.6%	[9.6%, 9.6%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 795.253s -> 795.718s (0.06%)
Artifact size: 336.22 MiB -> 335.54 MiB (-0.20%)

compiler-errors · 2024-11-23T15:40:09Z

@bors try @rust-timer queue

…=<try> Make `compare_impl_item` into a query First want to perf, then I'll write something up. r? `@ghost`

bors · 2024-11-23T15:41:19Z

⌛ Trying commit 1b30977 with merge d249c37...

bors · 2024-11-23T15:55:33Z

💔 Test failed - checks-actions

compiler-errors · 2024-11-23T16:05:39Z

@bors try @rust-timer queue

bors · 2024-11-23T16:06:48Z

⌛ Trying commit 4ece9e6 with merge 9dedd09...

…=<try> Make `compare_impl_item` into a query First want to perf, then I'll write something up. r? `@ghost`

bors · 2024-11-23T17:50:26Z

☀️ Try build successful - checks-actions
Build commit: 9dedd09 (9dedd0907e6ca8addde92511267c83ff2d1f6a22)

compiler/rustc_hir_analysis/src/check/compare_impl_item.rs

compiler/rustc_middle/src/query/mod.rs

compiler-errors · 2024-11-26T00:31:24Z

@bors r-

compiler-errors · 2024-11-26T00:56:04Z

Addressed the nits, so I'm just gonna re-approve it

@bors r=lcnr

bors · 2024-11-26T00:56:07Z

📌 Commit a1d9da3 has been approved by lcnr

It is now in the queue for this repository.

bors · 2024-11-26T08:04:44Z

⌛ Testing commit a1d9da3 with merge 4db5daa...

…=lcnr Make `compare_impl_item` into a query Turns `compare_impl_item` into a query (generalizing the existing query for `compare_impl_const`), and uses that in `Instance::resolve` to fail resolution when an implementation is incompatible with the trait it comes from. Fixes rust-lang#119701 Fixes rust-lang#121127 Fixes rust-lang#121411 Fixes rust-lang#129075 Fixes rust-lang#129127 Fixes rust-lang#129214 Fixes rust-lang#131294

rust-log-analyzer · 2024-11-26T09:25:01Z

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 Downloading crates ...
  Downloaded bar v0.1.0 (registry `dummy-registry`)
   Compiling bar v0.1.0
   Compiling foo v0.1.0
error: couldn't create a temp dir: Access is denied. (os error 5) at path "C:\\a\\_temp\\msys64\\tmp\\rustcCPaU8S"
error: could not compile `bar` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
warning: build failed, waiting for other jobs to finish...
error: failed to compile `foo v0.1.0`, intermediate artifacts can be found at `C:\a\_temp\msys64\tmp\cargo-installqSUfeH`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.


failures:
    install::lock_file_path_deps_ok

bors · 2024-11-26T09:25:39Z

💔 Test failed - checks-actions

lcnr · 2024-11-26T10:42:01Z

@bors retry

…=lcnr Make `compare_impl_item` into a query Turns `compare_impl_item` into a query (generalizing the existing query for `compare_impl_const`), and uses that in `Instance::resolve` to fail resolution when an implementation is incompatible with the trait it comes from. Fixes rust-lang#119701 Fixes rust-lang#121127 Fixes rust-lang#121411 Fixes rust-lang#129075 Fixes rust-lang#129127 Fixes rust-lang#129214 Fixes rust-lang#131294

bors · 2024-11-27T00:42:39Z

⌛ Testing commit a1d9da3 with merge 5857540...

rust-log-analyzer · 2024-11-27T02:11:51Z

The job x86_64-fuchsia failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[3396/20982] CLIPPY //src/developer/ffx/command:lib.actual.clippy(//build/toolchain:host_x64)
[3397/20982] RUST host_x64/obj/src/lib/transfer_manifest/libtransfer_manifest.rlib host_x64/obj/src/lib/transfer_manifest/libtransfer_manifest.rmeta
[3398/20982] CLIPPY //src/lib/transfer_manifest:transfer_manifest.actual.clippy(//build/toolchain:host_x64)
[3399/20982] RUST host_x64/obj/src/sys/lib/cm_types/libcm_types.rlib host_x64/obj/src/sys/lib/cm_types/libcm_types.rmeta
FAILED: host_x64/obj/src/sys/lib/cm_types/libcm_types.rlib host_x64/obj/src/sys/lib/cm_types/libcm_types.rmeta 
 RUST_BACKTRACE=1 ../../../install/bin/rustc --color=always --crate-name cm_types ../../src/sys/lib/cm_types/src/lib.rs --crate-type rlib --emit=dep-info=host_x64/obj/src/sys/lib/cm_types/libcm_types.rlib.d,link,metadata=host_x64/obj/src/sys/lib/cm_types/libcm_types.rmeta -Zdep-info-omit-d-target -Cmetadata=host_x64/obj/src/sys/lib/cm_types\ cm_types @rust_api_level_cfg_flags.txt --cfg=__rust_toolchain=\"07de3058cb9fa46ca0c34d03140868755f70f77f\" -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/clang++ -Cdefault-linker-libraries -Clink-arg=--sysroot=../../prebuilt/third_party/sysroot/linux -Clink-arg=--target=x86_64-unknown-linux-gnu -Clink-arg=-stdlib=libc++ -Clink-arg=--start-no-unused-arguments -Clink-arg=-unwindlib=libunwind -Clink-arg=-rtlib=compiler-rt -Clink-arg=--end-no-unused-arguments -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,--build-id -Zremap-cwd-prefix=. -Copt-level=0 -Cdebuginfo=0 -Clink-arg=-gz=zstd -Cdebug-assertions=yes -Zallow-features= --target x86_64-unknown-linux-gnu --cap-lints=warn -Wrust-2018-idioms -Dderef-nullptr -Dinvalid-value -Dunused-must-use -Aunknown_lints -Anon_local_definitions -Aelided_named_lifetimes -Dwarnings -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/clang++ -Cdefault-linker-libraries -Clink-arg=--sysroot=../../prebuilt/third_party/sysroot/linux -Clink-arg=--target=x86_64-unknown-linux-gnu -Clink-arg=-stdlib=libc++ -Clink-arg=--start-no-unused-arguments -Clink-arg=-unwindlib=libunwind -Clink-arg=-rtlib=compiler-rt -Clink-arg=--end-no-unused-arguments -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,--build-id -Clink-arg=-fPIE -Clink-arg=-pie -Clink-arg=-static-libstdc++ -Clink-arg=-Wl,-rpath=\$ORIGIN/ -Wunused_crate_dependencies -Dunused_results -Aunused_results --edition=2021 -o host_x64/obj/src/sys/lib/cm_types/libcm_types.rlib -Ldependency=host_x64/obj/sdk/fidl/fuchsia.component.decl/fuchsia.component.decl_rust -Ldependency=host_x64/obj/sdk/rust/zx-status -Ldependency=host_x64/obj/sdk/rust/zx-types -Ldependency=host_x64/obj/third_party/rust_crates -Ldependency=host_x64/obj/src/lib/fidl/rust/fidl -Ldependency=host_x64/obj/src/lib/fuchsia-async -Ldependency=host_x64/obj/src/lib/fuchsia-async-macro -Ldependency=host_x64/obj/src/lib/fuchsia-sync -Ldependency=host_x64/obj/sdk/fidl/fuchsia.data/fuchsia.data_rust -Ldependency=host_x64/obj/sdk/fidl/fuchsia.io/fuchsia.io_rust -Ldependency=host_x64/obj/sdk/fidl/fuchsia.unknown/fuchsia.unknown_rust -Ldependency=host_x64/obj/sdk/fidl/fuchsia.url/fuchsia.url_rust -Ldependency=host_x64/obj/src/lib/flyweights -Ldependency=host_x64/obj/src/storage/lib/vfs/rust/name --extern fidl_fuchsia_component_decl=host_x64/obj/sdk/fidl/fuchsia.component.decl/fuchsia.component.decl_rust/libfidl_fuchsia_component_decl.rlib --extern serde=host_x64/obj/third_party/rust_crates/libserde-3003bfce3ce79844.rlib --extern lazy_static=host_x64/obj/third_party/rust_crates/liblazy_static-cdf593bd3fb3d68f.rlib --extern thiserror=host_x64/obj/third_party/rust_crates/libthiserror-8a07473555bc0167.rlib --extern fidl_fuchsia_io=host_x64/obj/sdk/fidl/fuchsia.io/fuchsia.io_rust/libfidl_fuchsia_io.rlib --extern flyweights=host_x64/obj/src/lib/flyweights/libflyweights.rlib --extern name=host_x64/obj/src/storage/lib/vfs/rust/name/libname.rlib --extern url=host_x64/obj/third_party/rust_crates/liburl-e3e32e41f41a4ac0.rlib
error[E0391]: cycle detected when checking effective visibilities
    |
note: ...which requires computing type of `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires computing type of opaque `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires borrow-checking `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires promoting constants in MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking if `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments` contains FFI-unwind calls...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires building MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires resolving instance `<RelativePath as IterablePath>::iter_segments`...
    |
    |
857 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:696:1: 696:35>::iter_segments` is compatible with trait definition...
    |
    |
697 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: ...which again requires checking effective visibilities, completing the cycle
note: cycle used when checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:296:1: 296:27>::iter_segments` is compatible with trait definition
    |
    |
297 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information
error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0391`.
[3400/20982] CLIPPY //src/developer/ffx/lib/ssh:lib.actual.clippy(//build/toolchain:host_x64)
[3400/20982] CLIPPY //src/developer/ffx/lib/ssh:lib.actual.clippy(//build/toolchain:host_x64)
[3401/20982] ACTION //third_party/rust_crates:xattr-v0_2_2.license(//build/toolchain:host_x64)
[3402/20982] RUST host_x64/obj/src/developer/ffx/lib/ssh/libffx_ssh.rlib host_x64/obj/src/developer/ffx/lib/ssh/libffx_ssh.rmeta
[3403/20982] RUST host_x64/obj/src/lib/from-enum/libfrom_enum_derive.so host_x64/obj/src/lib/from-enum/libfrom_enum_derive.rmeta
[3404/20982] ACTION //zircon/system/ulib/c:verify_abi(//zircon/system/ulib/c:user.libc_x64)
[3405/20982] CLIPPY //src/sys/lib/cm_types:cm_types.actual.clippy(//build/toolchain:host_x64)
FAILED: host_x64/gen/src/sys/lib/cm_types/cm_types.actual.clippy 
../../build/rust/clippy_wrapper.sh --output host_x64/gen/src/sys/lib/cm_types/cm_types.actual.clippy --jq ../../prebuilt/third_party/jq/linux-x64/bin/jq --deps host_x64/gen/src/sys/lib/cm_types/cm_types.aux.deps.rmeta --transdeps host_x64/gen/src/sys/lib/cm_types/cm_types.aux.transdeps --fail -- env  ../../../install/bin/clippy-driver ../../src/sys/lib/cm_types/src/lib.rs --sysroot=../../../install --crate-type=rlib --cfg=__rust_toolchain=\"07de3058cb9fa46ca0c34d03140868755f70f77f\" -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/clang++ -Cdefault-linker-libraries -Clink-arg=--sysroot=../../prebuilt/third_party/sysroot/linux -Clink-arg=--target=x86_64-unknown-linux-gnu -Clink-arg=-stdlib=libc++ -Clink-arg=--start-no-unused-arguments -Clink-arg=-unwindlib=libunwind -Clink-arg=-rtlib=compiler-rt -Clink-arg=--end-no-unused-arguments -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,--build-id -Zremap-cwd-prefix=. -Copt-level=0 -Cdebuginfo=0 -Clink-arg=-gz=zstd -Cdebug-assertions=yes -Zallow-features= --target x86_64-unknown-linux-gnu --cap-lints=warn -Wrust-2018-idioms -Dderef-nullptr -Dinvalid-value -Dunused-must-use -Aunknown_lints -Anon_local_definitions -Aelided_named_lifetimes -Dwarnings -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/clang++ -Cdefault-linker-libraries -Clink-arg=--sysroot=../../prebuilt/third_party/sysroot/linux -Clink-arg=--target=x86_64-unknown-linux-gnu -Clink-arg=-stdlib=libc++ -Clink-arg=--start-no-unused-arguments -Clink-arg=-unwindlib=libunwind -Clink-arg=-rtlib=compiler-rt -Clink-arg=--end-no-unused-arguments -Clink-arg=-fuse-ld=lld -Clink-arg=-Wl,--build-id -Clink-arg=-fPIE -Clink-arg=-pie -Clink-arg=-static-libstdc++ -Clink-arg=-Wl,-rpath=\$ORIGIN/ -Wunused_crate_dependencies -Dunused_results -Aunused_results --edition=2021 -Aclippy::all -Dclippy::correctness -Dclippy::missing_safety_doc -Wclippy::expect_fun_call -Wclippy::large_enum_variant -Wclippy::large_futures -Wclippy::unnecessary_mut_passed -Cmetadata=clippy -Cmetadata=host_x64/obj/src/sys/lib/cm_types\ cm_types @rust_api_level_cfg_flags.txt
error[E0391]: cycle detected when checking effective visibilities
    |
note: ...which requires computing type of `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires computing type of opaque `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires borrow-checking `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires promoting constants in MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking if `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments` contains FFI-unwind calls...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires building MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires resolving instance `<RelativePath as IterablePath>::iter_segments`...
    |
    |
857 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:696:1: 696:35>::iter_segments` is compatible with trait definition...
    |
    |
697 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: ...which again requires checking effective visibilities, completing the cycle
note: cycle used when checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:296:1: 296:27>::iter_segments` is compatible with trait definition
    |
    |
297 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information

error: aborting due to 1 previous error


---
[4948/20982] CXX obj/sdk/lib/async/libasync-cpp.task.cc.o
[4949/20982] ACTION //third_party/rust_crates:log-v0_4_22.license(//build/toolchain/fuchsia:x64)
[4950/20982] ACTION //third_party/rust_crates:overload-v0_1_1.license(//build/toolchain/fuchsia:x64)
[4951/20982] RUST obj/src/sys/lib/cm_types/libcm_types.rlib obj/src/sys/lib/cm_types/libcm_types.rmeta
FAILED: obj/src/sys/lib/cm_types/libcm_types.rlib obj/src/sys/lib/cm_types/libcm_types.rmeta 
 RUST_BACKTRACE=1 ../../../install/bin/rustc --color=always --crate-name cm_types ../../src/sys/lib/cm_types/src/lib.rs --crate-type rlib --emit=dep-info=obj/src/sys/lib/cm_types/libcm_types.rlib.d,link,metadata=obj/src/sys/lib/cm_types/libcm_types.rmeta -Zdep-info-omit-d-target -Cmetadata=obj/src/sys/lib/cm_types\ cm_types @rust_api_level_cfg_flags.txt --cfg=__rust_toolchain=\"07de3058cb9fa46ca0c34d03140868755f70f77f\" -L gen/zircon/public/sysroot/cpp/lib -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/lld -Clink-arg=--sysroot=gen/zircon/public/sysroot/cpp -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/bin/../lib/x86_64-unknown-fuchsia/noexcept -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/lib/clang/20/lib/x86_64-unknown-fuchsia -Clink-arg=--pack-dyn-relocs=relr -Clink-arg=-dynamic-linker=ld.so.1 -Clink-arg=--icf=all -Clink-arg=-zrel -Zremap-cwd-prefix=. -Cforce-frame-pointers -Copt-level=0 -Cdebuginfo=0 -Clink-arg=--compress-debug-sections=zstd -Cdebug-assertions=yes -Zallow-features= --target x86_64-unknown-fuchsia --cap-lints=warn -Wrust-2018-idioms -Dderef-nullptr -Dinvalid-value -Dunused-must-use -Aunknown_lints -Anon_local_definitions -Aelided_named_lifetimes -Dwarnings -Cprefer-dynamic -Clink-args=-zstack-size=0x200000 -Cpanic=abort -Cforce-unwind-tables=yes -Zpanic_abort_tests -Csymbol-mangling-version=v0 -Wunused_crate_dependencies -Dunused_results -Aunused_results --edition=2021 -o obj/src/sys/lib/cm_types/libcm_types.rlib -Ldependency=obj/sdk/fidl/fuchsia.component.decl/fuchsia.component.decl_rust -Ldependency=obj/sdk/rust/zx-status -Ldependency=obj/sdk/rust/zx-types -Ldependency=obj/third_party/rust_crates -Ldependency=host_x64/obj/third_party/rust_crates -Ldependency=obj/src/lib/fidl/rust/fidl -Ldependency=obj/src/lib/fuchsia-async -Ldependency=host_x64/obj/src/lib/fuchsia-async-macro -Ldependency=obj/sdk/rust/zx -Ldependency=obj/zircon/vdso/zx_zither.rust_syscall -Ldependency=obj/src/lib/fuchsia-sync -Ldependency=obj/sdk/fidl/fuchsia.data/fuchsia.data_rust -Ldependency=obj/sdk/fidl/fuchsia.io/fuchsia.io_rust -Ldependency=obj/sdk/fidl/fuchsia.unknown/fuchsia.unknown_rust -Ldependency=obj/sdk/fidl/fuchsia.url/fuchsia.url_rust -Ldependency=obj/src/lib/flyweights -Ldependency=obj/src/storage/lib/vfs/rust/name -Clink-arg=-Bdynamic -Clink-arg=x64-shared/link_stub/libfdio.so -Clink-arg=obj/zircon/system/ulib/sync/libsync.a -Lnative=gen/src/zircon/lib/zircon/zircon.x86_64 -Clink-arg=gen/src/zircon/lib/zircon/zircon.x86_64/libzircon.so --extern fidl_fuchsia_component_decl=obj/sdk/fidl/fuchsia.component.decl/fuchsia.component.decl_rust/libfidl_fuchsia_component_decl.rlib --extern serde=obj/third_party/rust_crates/libserde-3003bfce3ce79844.rlib --extern lazy_static=obj/third_party/rust_crates/liblazy_static-cdf593bd3fb3d68f.rlib --extern thiserror=obj/third_party/rust_crates/libthiserror-8a07473555bc0167.rlib --extern fidl_fuchsia_io=obj/sdk/fidl/fuchsia.io/fuchsia.io_rust/libfidl_fuchsia_io.rlib --extern flyweights=obj/src/lib/flyweights/libflyweights.rlib --extern name=obj/src/storage/lib/vfs/rust/name/libname.rlib --extern url=obj/third_party/rust_crates/liburl-e3e32e41f41a4ac0.rlib
error[E0391]: cycle detected when checking effective visibilities
    |
note: ...which requires computing type of `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires computing type of opaque `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires borrow-checking `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires promoting constants in MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking if `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments` contains FFI-unwind calls...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires building MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires resolving instance `<RelativePath as IterablePath>::iter_segments`...
    |
    |
857 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:696:1: 696:35>::iter_segments` is compatible with trait definition...
    |
    |
697 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: ...which again requires checking effective visibilities, completing the cycle
note: cycle used when checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:296:1: 296:27>::iter_segments` is compatible with trait definition
    |
    |
297 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information
error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0391`.
[4952/20982] CXX obj/sdk/lib/async/libasync-cpp.trap.cc.o
[4952/20982] CXX obj/sdk/lib/async/libasync-cpp.trap.cc.o
[4953/20982] CLIPPY //src/sys/lib/cm_types:cm_types.actual.clippy(//build/toolchain/fuchsia:x64)
FAILED: gen/src/sys/lib/cm_types/cm_types.actual.clippy 
../../build/rust/clippy_wrapper.sh --output gen/src/sys/lib/cm_types/cm_types.actual.clippy --jq ../../prebuilt/third_party/jq/linux-x64/bin/jq --deps gen/src/sys/lib/cm_types/cm_types.aux.deps.rmeta --transdeps gen/src/sys/lib/cm_types/cm_types.aux.transdeps --fail -- env  ../../../install/bin/clippy-driver ../../src/sys/lib/cm_types/src/lib.rs --sysroot=../../../install --crate-type=rlib --cfg=__rust_toolchain=\"07de3058cb9fa46ca0c34d03140868755f70f77f\" -L gen/zircon/public/sysroot/cpp/lib -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/lld -Clink-arg=--sysroot=gen/zircon/public/sysroot/cpp -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/bin/../lib/x86_64-unknown-fuchsia/noexcept -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/lib/clang/20/lib/x86_64-unknown-fuchsia -Clink-arg=--pack-dyn-relocs=relr -Clink-arg=-dynamic-linker=ld.so.1 -Clink-arg=--icf=all -Clink-arg=-zrel -Zremap-cwd-prefix=. -Cforce-frame-pointers -Copt-level=0 -Cdebuginfo=0 -Clink-arg=--compress-debug-sections=zstd -Cdebug-assertions=yes -Zallow-features= --target x86_64-unknown-fuchsia --cap-lints=warn -Wrust-2018-idioms -Dderef-nullptr -Dinvalid-value -Dunused-must-use -Aunknown_lints -Anon_local_definitions -Aelided_named_lifetimes -Dwarnings -Cprefer-dynamic -Clink-args=-zstack-size=0x200000 -Cpanic=abort -Cforce-unwind-tables=yes -Zpanic_abort_tests -Csymbol-mangling-version=v0 -Wunused_crate_dependencies -Dunused_results -Aunused_results --edition=2021 -Aclippy::all -Dclippy::correctness -Dclippy::missing_safety_doc -Wclippy::expect_fun_call -Wclippy::large_enum_variant -Wclippy::large_futures -Wclippy::unnecessary_mut_passed -Cmetadata=clippy -Cmetadata=obj/src/sys/lib/cm_types\ cm_types @rust_api_level_cfg_flags.txt
error[E0391]: cycle detected when checking effective visibilities
    |
note: ...which requires computing type of `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires computing type of opaque `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires borrow-checking `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires promoting constants in MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking if `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments` contains FFI-unwind calls...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires building MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires resolving instance `<RelativePath as IterablePath>::iter_segments`...
    |
    |
857 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:696:1: 696:35>::iter_segments` is compatible with trait definition...
    |
    |
697 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: ...which again requires checking effective visibilities, completing the cycle
note: cycle used when checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:296:1: 296:27>::iter_segments` is compatible with trait definition
    |
    |
297 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information

error: aborting due to 1 previous error


---
[6166/20982] CXX host_x64/obj/third_party/protobuf/src/google/protobuf/compiler/python/libprotoc_lib.generator.cc.o
[6167/20982] CC x64-shared/obj/third_party/boringssl/src/crypto/asn1/libcrypto.a_bitstr.c.o
[6168/20982] CC x64-shared/obj/third_party/boringssl/src/crypto/asn1/libcrypto.a_bool.c.o
[6169/20982] RUST x64-shared/obj/src/sys/lib/cm_types/libcm_types.rlib x64-shared/obj/src/sys/lib/cm_types/libcm_types.rmeta
FAILED: x64-shared/obj/src/sys/lib/cm_types/libcm_types.rlib x64-shared/obj/src/sys/lib/cm_types/libcm_types.rmeta 
 RUST_BACKTRACE=1 ../../../install/bin/rustc --color=always --crate-name cm_types ../../src/sys/lib/cm_types/src/lib.rs --crate-type rlib --emit=dep-info=x64-shared/obj/src/sys/lib/cm_types/libcm_types.rlib.d,link,metadata=x64-shared/obj/src/sys/lib/cm_types/libcm_types.rmeta -Zdep-info-omit-d-target -Cmetadata=x64-shared/obj/src/sys/lib/cm_types\ cm_types @rust_api_level_cfg_flags.txt --cfg=__rust_toolchain=\"07de3058cb9fa46ca0c34d03140868755f70f77f\" -L x64-shared/gen/zircon/public/sysroot/cpp/lib -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/lld -Clink-arg=--sysroot=x64-shared/gen/zircon/public/sysroot/cpp -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/bin/../lib/x86_64-unknown-fuchsia/noexcept -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/lib/clang/20/lib/x86_64-unknown-fuchsia -Clink-arg=--pack-dyn-relocs=relr -Clink-arg=-dynamic-linker=ld.so.1 -Clink-arg=--icf=all -Clink-arg=-zrel -Zremap-cwd-prefix=. -Cforce-frame-pointers -Copt-level=0 -Cdebuginfo=0 -Clink-arg=--compress-debug-sections=zstd -Cdebug-assertions=yes -Zallow-features= --target x86_64-unknown-fuchsia --cap-lints=warn -Wrust-2018-idioms -Dderef-nullptr -Dinvalid-value -Dunused-must-use -Aunknown_lints -Anon_local_definitions -Aelided_named_lifetimes -Dwarnings -Cprefer-dynamic -Clink-args=-zstack-size=0x200000 -Cpanic=abort -Cforce-unwind-tables=yes -Zpanic_abort_tests -Csymbol-mangling-version=v0 -Wunused_crate_dependencies -Dunused_results -Aunused_results --edition=2021 -o x64-shared/obj/src/sys/lib/cm_types/libcm_types.rlib -Ldependency=x64-shared/obj/sdk/fidl/fuchsia.component.decl/fuchsia.component.decl_rust -Ldependency=x64-shared/obj/sdk/rust/zx-status -Ldependency=x64-shared/obj/sdk/rust/zx-types -Ldependency=x64-shared/obj/third_party/rust_crates -Ldependency=host_x64/obj/third_party/rust_crates -Ldependency=x64-shared/obj/src/lib/fidl/rust/fidl -Ldependency=x64-shared/obj/src/lib/fuchsia-async -Ldependency=host_x64/obj/src/lib/fuchsia-async-macro -Ldependency=x64-shared/obj/sdk/rust/zx -Ldependency=x64-shared/obj/zircon/vdso/zx_zither.rust_syscall -Ldependency=x64-shared/obj/src/lib/fuchsia-sync -Ldependency=x64-shared/obj/sdk/fidl/fuchsia.data/fuchsia.data_rust -Ldependency=x64-shared/obj/sdk/fidl/fuchsia.io/fuchsia.io_rust -Ldependency=x64-shared/obj/sdk/fidl/fuchsia.unknown/fuchsia.unknown_rust -Ldependency=x64-shared/obj/sdk/fidl/fuchsia.url/fuchsia.url_rust -Ldependency=x64-shared/obj/src/lib/flyweights -Ldependency=x64-shared/obj/src/storage/lib/vfs/rust/name -Clink-arg=-Bdynamic -Clink-arg=x64-shared/link_stub/libfdio.so -Clink-arg=x64-shared/obj/zircon/system/ulib/sync/libsync.a -Lnative=gen/src/zircon/lib/zircon/zircon.x86_64 -Clink-arg=gen/src/zircon/lib/zircon/zircon.x86_64/libzircon.so --extern fidl_fuchsia_component_decl=x64-shared/obj/sdk/fidl/fuchsia.component.decl/fuchsia.component.decl_rust/libfidl_fuchsia_component_decl.rlib --extern serde=x64-shared/obj/third_party/rust_crates/libserde-3003bfce3ce79844.rlib --extern lazy_static=x64-shared/obj/third_party/rust_crates/liblazy_static-cdf593bd3fb3d68f.rlib --extern thiserror=x64-shared/obj/third_party/rust_crates/libthiserror-8a07473555bc0167.rlib --extern fidl_fuchsia_io=x64-shared/obj/sdk/fidl/fuchsia.io/fuchsia.io_rust/libfidl_fuchsia_io.rlib --extern flyweights=x64-shared/obj/src/lib/flyweights/libflyweights.rlib --extern name=x64-shared/obj/src/storage/lib/vfs/rust/name/libname.rlib --extern url=x64-shared/obj/third_party/rust_crates/liburl-e3e32e41f41a4ac0.rlib
error[E0391]: cycle detected when checking effective visibilities
    |
note: ...which requires computing type of `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires computing type of opaque `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires borrow-checking `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires promoting constants in MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking if `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments` contains FFI-unwind calls...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires building MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires resolving instance `<RelativePath as IterablePath>::iter_segments`...
    |
    |
857 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:696:1: 696:35>::iter_segments` is compatible with trait definition...
    |
    |
697 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: ...which again requires checking effective visibilities, completing the cycle
note: cycle used when checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:296:1: 296:27>::iter_segments` is compatible with trait definition
    |
    |
297 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information
error: aborting due to 1 previous error

For more information about this error, try `rustc --explain E0391`.
[6170/20982] CC x64-shared/obj/third_party/boringssl/src/crypto/asn1/libcrypto.a_d2i_fp.c.o
[6170/20982] CC x64-shared/obj/third_party/boringssl/src/crypto/asn1/libcrypto.a_d2i_fp.c.o
[6171/20982] CC x64-shared/obj/third_party/boringssl/src/crypto/asn1/libcrypto.a_dup.c.o
[6172/20982] CLIPPY //src/sys/lib/cm_types:cm_types.actual.clippy(//build/toolchain/fuchsia:x64-shared)
FAILED: x64-shared/gen/src/sys/lib/cm_types/cm_types.actual.clippy 
../../build/rust/clippy_wrapper.sh --output x64-shared/gen/src/sys/lib/cm_types/cm_types.actual.clippy --jq ../../prebuilt/third_party/jq/linux-x64/bin/jq --deps x64-shared/gen/src/sys/lib/cm_types/cm_types.aux.deps.rmeta --transdeps x64-shared/gen/src/sys/lib/cm_types/cm_types.aux.transdeps --fail -- env  ../../../install/bin/clippy-driver ../../src/sys/lib/cm_types/src/lib.rs --sysroot=../../../install --crate-type=rlib --cfg=__rust_toolchain=\"07de3058cb9fa46ca0c34d03140868755f70f77f\" -L x64-shared/gen/zircon/public/sysroot/cpp/lib -Clinker=../../prebuilt/third_party/clang/linux-x64/bin/lld -Clink-arg=--sysroot=x64-shared/gen/zircon/public/sysroot/cpp -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/bin/../lib/x86_64-unknown-fuchsia/noexcept -Clink-arg=-L../../prebuilt/third_party/clang/linux-x64/lib/clang/20/lib/x86_64-unknown-fuchsia -Clink-arg=--pack-dyn-relocs=relr -Clink-arg=-dynamic-linker=ld.so.1 -Clink-arg=--icf=all -Clink-arg=-zrel -Zremap-cwd-prefix=. -Cforce-frame-pointers -Copt-level=0 -Cdebuginfo=0 -Clink-arg=--compress-debug-sections=zstd -Cdebug-assertions=yes -Zallow-features= --target x86_64-unknown-fuchsia --cap-lints=warn -Wrust-2018-idioms -Dderef-nullptr -Dinvalid-value -Dunused-must-use -Aunknown_lints -Anon_local_definitions -Aelided_named_lifetimes -Dwarnings -Cprefer-dynamic -Clink-args=-zstack-size=0x200000 -Cpanic=abort -Cforce-unwind-tables=yes -Zpanic_abort_tests -Csymbol-mangling-version=v0 -Wunused_crate_dependencies -Dunused_results -Aunused_results --edition=2021 -Aclippy::all -Dclippy::correctness -Dclippy::missing_safety_doc -Wclippy::expect_fun_call -Wclippy::large_enum_variant -Wclippy::large_futures -Wclippy::unnecessary_mut_passed -Cmetadata=clippy -Cmetadata=x64-shared/obj/src/sys/lib/cm_types\ cm_types @rust_api_level_cfg_flags.txt
error[E0391]: cycle detected when checking effective visibilities
    |
note: ...which requires computing type of `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires computing type of opaque `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments::{opaque#0}`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires borrow-checking `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires promoting constants in MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking if `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments` contains FFI-unwind calls...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires building MIR for `<impl at ../../src/sys/lib/cm_types/src/lib.rs:382:1: 382:36>::iter_segments`...
    |
    |
383 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires resolving instance `<RelativePath as IterablePath>::iter_segments`...
    |
    |
857 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send;
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...which requires checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:696:1: 696:35>::iter_segments` is compatible with trait definition...
    |
    |
697 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: ...which again requires checking effective visibilities, completing the cycle
note: cycle used when checking assoc item `<impl at ../../src/sys/lib/cm_types/src/lib.rs:296:1: 296:27>::iter_segments` is compatible with trait definition
    |
    |
297 |     fn iter_segments(&self) -> impl DoubleEndedIterator<Item = &Name> + Send {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    = note: see https://rustc-dev-guide.rust-lang.org/overview.html#queries and https://rustc-dev-guide.rust-lang.org/query.html for more information

error: aborting due to 1 previous error

bors · 2024-11-27T02:12:42Z

💔 Test failed - checks-actions

compiler-errors · 2024-11-27T02:29:51Z

lmao, ok I think I know how to turn this into a cycle 🤔

should be able to fix this by removing the refinement check from this logic

lcnr · 2024-11-27T08:06:39Z

gamer!

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 23, 2024