Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename opensbd to openbsd #85738

Merged
merged 1 commit into from
May 27, 2021
Merged

Rename opensbd to openbsd #85738

merged 1 commit into from
May 27, 2021

Conversation

370417
Copy link
Contributor

@370417 370417 commented May 27, 2021

OpenBsd was sometimes spelled "opensbd" in the standard library.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2021
@CDirkx
Copy link
Contributor

CDirkx commented May 27, 2021

This enables OpenBSD to now correctly benefit from certain cloexec optimizations 👍🏻

@m-ou-se m-ou-se added O-openbsd Operating system: OpenBSD T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 27, 2021
@m-ou-se m-ou-se assigned m-ou-se and unassigned yaahc May 27, 2021
@m-ou-se
Copy link
Member

m-ou-se commented May 27, 2021

Good catch! Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented May 27, 2021

📌 Commit 3cafe2a has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2021
@est31 est31 mentioned this pull request May 27, 2021
Closed
@est31
Copy link
Member

est31 commented May 27, 2021

Hmm I wonder whether one could add add a lint for detecting cases like this: #85753

@GuillaumeGomez GuillaumeGomez mentioned this pull request May 27, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 27, 2021
@bors
Auto merge of rust-lang#85757 - GuillaumeGomez:rollup-k8hfhp8, r=Guil…
e51830b 
…laumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#85722 (Fix trait methods' toggle)
 - rust-lang#85730 (Mention workaround for floats in Iterator::{min, max})
 - rust-lang#85738 (Rename opensbd to openbsd)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@jsoref
Copy link
Contributor

jsoref commented May 27, 2021

@est31: At some point I'd be happy to offer https://github.com/marketplace/actions/check-spelling

@bors bors merged commit 48706ed into rust-lang:master May 27, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 27, 2021
@370417 370417 deleted the opensbd branch May 28, 2021 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
O-openbsd Operating system: OpenBSD S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
9 participants
@370417 @rust-highfive @CDirkx @m-ou-se @bors @est31 @jsoref @yaahc @rustbot