Rollup of 11 pull requests #86127
Merged
Rollup of 11 pull requests #86127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are tracked in src/tools/rustfmt/.gitattributes already, they don't need to be listed twice.
Prior to this patch, the default panic message (resulting from calling `panic_any(42);` for example), would print the following error message: ``` thread 'main' panicked at 'Box<Any>', ... ``` However, this should be `Box<dyn Any>` instead.
This patch fixes tests from failing that were matching on `Box<Any>`, which was the old panic message. Since the new panic message is `Box<dyn Any>`, the tests have been updated to match against this instead.
Use `Iterator::find` instead of open-coding it ```@rustbot``` modify labels +C-cleanup +T-compiler
…eklabnik Update the documentation of `-C force-unwind-tables` for rust-lang#83482 `panic=unwind` does not require `force-unwind-tables` to be "yes" anymore. I forgot to update this in rust-lang#83482.
Clarify documentation of slice sorting methods After reading about [this](https://polkadot.network/a-polkadot-postmortem-24-05-2021/), I realized that although the documentation of these methods is not ambiguous in its current state, it is very easy to read it and erroneously assume that their exact behaviour can be relied upon to be deterministic. Although the docs make no guarantees about which index is returned when there are multiple matches, being more explicit about when and how their determinism can be relied upon should help prevent people from making this mistake in the future. r? ``@steveklabnik``
Remove rustfmt tests from top-level .gitattributes These are tracked in src/tools/rustfmt/.gitattributes already, they don't need to be listed twice. r? `@ehuss` since you suggested adding them in rust-lang#82208; I think it should be ok now that bors isn't trying to merge the `subtree add` changes. cc `@calebcartwright`
Default panic message should print Box<dyn Any> Closes rust-lang#86039 Prior to this patch, the panic message from running the following code would be `thread 'main' panicked at 'Box<Any>'...` ```rust use std::panic::panic_any; fn main() { panic_any(42); } ``` This patch updates the phrasing to be more consistent. It now instead shows the following panic message: ``` thread 'main' panicked at 'Box<dyn Any>', ... ``` It's a very small fix 😄
…t, r=jsha Type page font weight Fixes rust-lang#86069. r? ```@jsha```
…=jonas-schievink ⬆️ rust-analyzer
…odeblock, r=jsha Search description codeblock The codeblocks are not displayed correctly:  This PR interprets the HTML correctly (and still prevent invalid HTML because of how it inserts it):  r? ```@jsha```
Comment out unused error codes and add description for E0316
I have added an extended description of `E0316` and commented out a bunch of unused error codes to make clear the fact that they are no longer in use. You can check for yourself with
```shell
for ec in \
E0314 E0315 E0473 E0474 E0475 E0479 E0480 E0481 \
E0483 E0484 E0485 E0486 E0487 E0488 E0489
do
if [ ! -z "`grep -r $ec compiler/* --exclude-dir=rustc_error_codes`" ]
then
echo $ec
false
fi
done
```
i.e. these error codes appear nowhere in the compiler code and thus cannot be emitted.
r? ```@GuillaumeGomez```
…r=m-ou-se Correct type signature in doc for Bound::as_mut Thanks to ``@drmason13`` for pointing this out!
Remove lifetime hack It compiles without the hack. But I don't know why. I can't get the example in the referenced issue to compile...
|
@bors r+ p=11 rollup=never |
|
📌 Commit b7fadfd has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jun 8, 2021
Tested on commit rust-lang/rust@a50d721. Direct link to PR: <rust-lang/rust#86127> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Iterator::findinstead of open-coding it #85906 (UseIterator::findinstead of open-coding it)-C force-unwind-tablesfor #83482 #85951 (Update the documentation of-C force-unwind-tablesfor Allow using-C force-unwind-tables=nowhenpanic=unwind#83482)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup