Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't consider predicates with HRTBs to be global during winnowing #95755

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Apr 7, 2022

Kinda along the same lines as #95611, predicates with for<'a> in them shouldn't be treated specially, and are (or should be treated) as "global" as predicates without bound variables.

Fixes #95640

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 7, 2022
@rust-highfive
Copy link
Collaborator

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2022
@compiler-errors compiler-errors force-pushed the hrtb-global-pred-candidate-assembly branch from e5fa723 to d3f9d71 Compare April 7, 2022 07:12
@compiler-errors
Copy link
Member Author

i guess this could also use a crater run

@bors try

@bors
Copy link
Contributor

bors commented Apr 10, 2022

⌛ Trying commit d3f9d71 with merge 9b06ec641f3d05c126a54ceadba42a64366f72b4...

@bors
Copy link
Contributor

bors commented Apr 10, 2022

☀️ Try build successful - checks-actions
Build commit: 9b06ec641f3d05c126a54ceadba42a64366f72b4 (9b06ec641f3d05c126a54ceadba42a64366f72b4)

@compiler-errors
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-95755 created and queued.
🤖 Automatically detected try build 9b06ec641f3d05c126a54ceadba42a64366f72b4
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2022
@craterbot
Copy link
Collaborator

🚧 Experiment pr-95755 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-95755 is completed!
📊 10 regressed and 7 fixed (225472 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Apr 21, 2022
@apiraino
Copy link
Contributor

I assume the action to unassign the reviewer is that this PR needs more work, so I'll update the labels accordingly. Please feel free to request a review when ready, thanks!

@rustbot -S-waiting-on-review +S-waiting-on-author

@apiraino apiraino added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2022
@compiler-errors
Copy link
Member Author

This is fixed by #96806 instead.

@compiler-errors compiler-errors deleted the hrtb-global-pred-candidate-assembly branch August 11, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: unimpl selecting .. during codegen with -Zmir-opt-level=3
7 participants