Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that closures satisfy their where bounds #96899

Merged
merged 2 commits into from
May 13, 2022
Merged

Check that closures satisfy their where bounds #96899

merged 2 commits into from
May 13, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented May 10, 2022 •
edited
Loading

fixes #53092
fixes #90409

based on #96736

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 10, 2022
@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2022
@oli-obk
Copy link
Contributor Author

oli-obk commented May 10, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2022
@bors
Copy link
Contributor

bors commented May 10, 2022

⌛ Trying commit 794022df66af9c5a1983cd84561f744df6b32c9c with merge d6ad50280b6dfbaf0163b0f18e58a204ba847da1...

@bors
Copy link
Contributor

bors commented May 10, 2022

☔ The latest upstream changes (presumably #96736) made this pull request unmergeable. Please resolve the merge conflicts.

@oli-obk
Copy link
Contributor Author

oli-obk commented May 10, 2022

@rust-timer build d6ad50280b6dfbaf0163b0f18e58a204ba847da1

@rust-timer
Copy link
Collaborator

Queued d6ad50280b6dfbaf0163b0f18e58a204ba847da1 with parent c51871c, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d6ad50280b6dfbaf0163b0f18e58a204ba847da1): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 10, 2022
@oli-obk oli-obk force-pushed the closure_wf_check_bounds branch from 1b2c19d to c19a3a1 Compare May 11, 2022 07:06
@nikomatsakis
Copy link
Contributor

r? @nikomatsakis

We reviewed this in a deep dive meeting.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2022

📌 Commit c19a3a1936bbb36dbf1a9f64541294e8e4ea7622 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2022
@bors
Copy link
Contributor

bors commented May 12, 2022

⌛ Testing commit c19a3a1936bbb36dbf1a9f64541294e8e4ea7622 with merge 630096dc68cf0cde55133389bef9934cf1d8f223...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented May 12, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2022
@oli-obk oli-obk force-pushed the closure_wf_check_bounds branch from c19a3a1 to 7a4ac84 Compare May 13, 2022 10:09
@oli-obk
Copy link
Contributor Author

oli-obk commented May 13, 2022

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented May 13, 2022

📌 Commit 7a4ac84 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2022
@bors
Copy link
Contributor

bors commented May 13, 2022

⌛ Testing commit 7a4ac84 with merge a7d6408...

@bors
Copy link
Contributor

bors commented May 13, 2022

☀️ Test successful - checks-actions
Approved by: nikomatsakis
Pushing a7d6408 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2022
@bors bors merged commit a7d6408 into rust-lang:master May 13, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 13, 2022
@oli-obk oli-obk deleted the closure_wf_check_bounds branch May 13, 2022 13:46
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a7d6408): comparison url.

Summary:

  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 0 0 0 1
mean2 0.2% N/A N/A N/A 0.2%
max 0.2% N/A N/A N/A 0.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩

  2. the arithmetic mean of the percent change ↩

@MingweiSamuel MingweiSamuel mentioned this pull request May 19, 2022
Closed
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this pull request May 19, 2022
@MingweiSamuel
Fix build by adding trait bounds to existential types
6b8d91f 
Fix hydro-project#150
rust-lang/rust#96899
@MingweiSamuel MingweiSamuel mentioned this pull request May 19, 2022
Merged
MingweiSamuel added a commit to hydro-project/hydroflow that referenced this pull request May 19, 2022
@MingweiSamuel
Fix build by adding trait bounds to existential types
0381ee7 
Fix #150
rust-lang/rust#96899
@compiler-errors compiler-errors mentioned this pull request Jun 1, 2022
Closed
@oli-obk oli-obk mentioned this pull request Jun 2, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 13, 2022
@bors
Auto merge of rust-lang#97642 - oli-obk:backport_undo_closure_wf_chec…
1bc802e 
…k, r=compiler-errors

Revert "Check that closures satisfy their where bounds"

This reverts commit 253408b from rust-lang#96899

This is only performed on beta to give us another few weeks to fix rust-lang#97607 on nightly. The planned fix is likely way too large to backport anyway.

r? `@compiler-errors`
@aliemjay aliemjay mentioned this pull request Jun 24, 2022
Open
@aliemjay aliemjay mentioned this pull request Aug 10, 2022
Open
@oli-obk oli-obk mentioned this pull request Sep 8, 2022
Closed
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 24, 2024
@MingweiSamuel
Fix build by adding trait bounds to existential types
79bcf7c 
Fix hydro-project#150
rust-lang/rust#96899
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 25, 2024
@MingweiSamuel
Fix build by adding trait bounds to existential types
08d3186 
Fix hydro-project#150
rust-lang/rust#96899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

ICE with missing bound in TAIT with closures/async FullfillmentError ICE with const fn and existential type
8 participants
@oli-obk @rust-highfive @rust-timer @bors @nikomatsakis @rust-log-analyzer @cjgillot @rustbot