-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make functions part of alloc_layout_extra
(#55724) const.
#99016
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
@rustbot label +T-libs-api -T-libs I think that is correct? |
Even though the changes look trivial, I recommend roll-up=iffy on this PR because seemingly noöp changes to the layout code have caused perf regressions before. |
☔ The latest upstream changes (presumably #99136) made this pull request unmergeable. Please resolve the merge conflicts. |
Hi, this is an API change and so needs to go through the ACP process, as described by the bot:
|
triage: adding blocked tag |
@rustbot label +S-waiting-on-ACP |
The constification of these methods has been merged in the (later submitted) PR #102207 |
Make functions part of
alloc_layout_extra
(#55724) const. Requires two additional feature flags:const_alloc_layout
andconst_try
(from my understanding std already builds with many other nightly features). I added them in alphabetical order. The only implementation change isstd::cmp::max
has to be replaced with an explicitif
expression since trait methods are not const.