Filter filenames in cg_diff for local builds, too #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
reviewed
May 16, 2022
| @@ -640,7 +640,7 @@ fn cg_diff(cgout1: &Path, cgout2: &Path, path: &Path) -> anyhow::Result<()> { | |||
| anyhow::bail!("`cg_diff` not installed."); | |||
| } | |||
| let output = Command::new("cg_diff") | |||
| .arg("--mod-filename=s#/rustc/[^/]*/##") | |||
There was a problem hiding this comment.
I'm failing to remember how this original regex works, I can't remember the synatx. What does it do?
There was a problem hiding this comment.
I don't know. When you get rustc from CI, the filenames are all ??? so this may just be useless nowadays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternatively we could make the regex string configurable so that changing it doesn't require rebuilds