Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the TUI for the benchmark suite #1991

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orhun
Copy link

@orhun orhun commented Oct 10, 2024

See mainmatter/eurorust-2024-impl-Room#9

cap

Warning

This is a PoC - expect hackathon code quality!

@Kobzol
Copy link
Contributor

Kobzol commented Oct 10, 2024

Thank you very much! I think that this is already in a pretty good shape (would be nice to eventually split the large function into a bunch of smaller once, but that's a detail).

In terms of the dependencies, the dependency count goes up from 307 to 329. However, if we get rid of inquire, which shouldn't be needed since we now got ratatui, it goes down to 321. And if we later also get rid of tabled, it goes back down to 309 :)

If you're up for it, it would be nice to get rid of inquire. Instead of the metric selection dialog, we could have a "select box" of metrics in the main TUI, with instructions being the default. Instead of the artifact selection dialog, we could have another ratatui screen that displays a table of artifacts and lets the user choose the ones they want to compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants