Triage 2024 11 19 #2012
Merged
Triage 2024 11 19 #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnethercote
approved these changes
Nov 20, 2024
lqd
reviewed
Nov 20, 2024
| | Improvements ✅ <br /> (secondary) | -9.9% | [-67.2%, -0.3%] | 22 | | ||
| | All ❌✅ (primary) | -5.4% | [-25.1%, 6.6%] | 83 | | ||
|
|
||
| * massive improvements; many incremental benchmarks are improved by 5% to 20% (and even 25% in the case of ripgrep) |
There was a problem hiding this comment.
this is great no doubt, also remember that changes to incremental data loading/hashing like this are over-represented in rustc-perf results because we force incremental hash verification all the time compared to rustc's 1/32 ratio (for stabilization purposes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.