Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase robustness of SSL renewing #393

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Increase robustness of SSL renewing #393

merged 1 commit into from
Apr 2, 2024

Conversation

shepmaster
Copy link
Member

The playground had an error renewing:

Error -> One or more domains had a problem:
error: 0 :: POST :: https://acme-v02.api.letsencrypt.org/acme/finalize/514094497/249375107307 :: urn:ietf:params:acme:error:rateLimited :: Service busy; retry later., url:

Our renew timer runs once a week at midnight UTC, and my guess is that lots of other servers across the world are doing the same thing causing temporary overloads. These changes are intended to help spread out the load a bit and retry when an error happens anyway.

Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of #311 as well, isn't it?

@shepmaster
Copy link
Member Author

Yep. This should be merged first and then I can rebase #311 .

Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then let's do that. 😁

The playground had an error renewing:

```
Error -> One or more domains had a problem:
error: 0 :: POST :: https://acme-v02.api.letsencrypt.org/acme/finalize/514094497/249375107307 :: urn:ietf:params:acme:error:rateLimited :: Service busy; retry later., url:
```

Our renew timer runs once a week at midnight UTC, and my guess is that
lots of other servers across the world are doing the same thing
causing temporary overloads. These changes are intended to help spread
out the load a bit and retry when an error happens anyway.
@shepmaster shepmaster merged commit 07c13a1 into master Apr 2, 2024
6 checks passed
@shepmaster shepmaster deleted the robust-ssl-renew branch April 2, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants