Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.5.7 #511

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

Thomasdezeeuw
Copy link
Collaborator

No description provided.

Comment on lines -3 to 13
* Add `Socket::(set_)multicast_all_v{4,6}`
* Added `Socket::(set_)multicast_all_v{4,6}`
(https://github.com/rust-lang/socket2/pull/485 and
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to change a convention for the changelog. You don't want a separate PR for that?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the convention consistent, we use both Add and Added before. I put it in a separate commit, which I'm not squashing, so I think it's fine.

@Thomasdezeeuw Thomasdezeeuw merged commit c8146aa into rust-lang:master Apr 29, 2024
41 checks passed
@Thomasdezeeuw Thomasdezeeuw deleted the release-v0.5.7 branch April 29, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants