Issue: #523 #524
Issue: #523 #524
Conversation
.idea/.gitignore
Outdated
There was a problem hiding this comment.
Can you remove this .idea directory from the commits?
There was a problem hiding this comment.
I removed it in later commits, is that enough?
There was a problem hiding this comment.
No, please rebase the commits.
| /// [`set_rcv_lowat`]: crate::Socket::set_rcv_lowat | ||
| // TODO: add Redox support, but I'm not sure if Redox supports SO_RCVLOWAT | ||
| #[cfg(all(feature = "all", not(target_os = "redox")))] | ||
| pub fn rcv_lowat(&self) -> io::Result<u32> { |
There was a problem hiding this comment.
Can we come up with more descriptive names for these functions?
There was a problem hiding this comment.
Maybe receive_lowat and send_lowat? Lowat stands for low water mark. maybe something with that?
Or we could add a get_ prefix which would not align with the naming conventions of these socket option getter functions, but would be more descriptive. You tell me, since I don't know how bad it is to break naming conventions in this repo.
|
It seems like the tests failed, I'm currently in my holidays, programming on a windows laptop :/. I can't run the unix tests locally. |
|
@Kleinmarb do you have time to work on this? |
Add support for the socket options named in #523,
fix some typos
and add .idea to .gitignore