Fix allow_auto_merge in combination with repository archiving
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be missing if the repository is archived.
Mark-Simulacrum
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow_auto_mergeis.TheActually, it should be fine, as the diff won't be missed, since we are unarchiving in the first place, so there is some diff.unwrap_or(false)part isn't ideal, but in this case we simply cannot query the GH state, so there's probably no way to calculate the real diff. In theory, this could cause us to miss auto-enabling auto merge for a repository that is being unarchived, during the first sync, but it should be resolved on the following sync.