Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: pin Rust version #80

Merged
merged 3 commits into from
Jun 3, 2024
Merged

CI: pin Rust version #80

merged 3 commits into from
Jun 3, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Mar 27, 2024

To avoid surprises with e.g. new Clippy errors breaking CI.

@Kobzol Kobzol force-pushed the ci-pin-rust-version branch from 48b6168 to b6f29ef Compare March 27, 2024 10:03
Kobzol added 2 commits March 27, 2024 11:59
@Kobzol
Update checkout version
c7b7e9a
@Kobzol
Pin Rust version used in CI
829a054 
To avoid surprises with e.g. new Clippy lints breaking CI.
@Kobzol Kobzol force-pushed the ci-pin-rust-version branch from b6f29ef to 829a054 Compare March 27, 2024 10:59
rylev
rylev approved these changes Mar 27, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Kobzol Kobzol requested a review from jdno May 29, 2024 16:22
jdno
jdno reviewed May 31, 2024
View reviewed changes
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add rust-toolchain.toml so that the same version is used locally and in CI?

@jdno
Copy link
Member

jdno commented May 31, 2024

Regarding Renovate, Tobias created a configuration snippet that updates the rust-toolchain.toml file: https://github.com/Turbo87/renovate-config/blob/master/rust/updateToolchain.json. Seems to work well for crates.io.

@Kobzol
Copy link
Contributor Author

Kobzol commented May 31, 2024

I don't think that either is really needed here, mostly because running sync-team locally is... quite challenging :) I just wanted to make CI more deterministic.

I added rust-toolchain.toml, updating it automatically is overkill, IMO.

jdno
jdno approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jdno
Copy link
Member

jdno commented Jun 3, 2024

I don't think that either is really needed here, mostly because running sync-team locally is... quite challenging :)

That is a fair argument! 😅 But I think using rust-toolchain.toml is a good pattern that we can use across other repos as well. I'd love for our developer experience to be as consistent as possible. Which right now it isn't really... 🙈

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 3, 2024

@jdno I don't have merge rights, so you'll also need to merge it.

@jdno jdno merged commit f235bd8 into rust-lang:master Jun 3, 2024
1 check passed
@Kobzol Kobzol deleted the ci-pin-rust-version branch June 3, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

@jdno jdno jdno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kobzol @jdno @rylev