teams/opsem.toml: Add joshlf to zulip-groups #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
requested changes
Nov 23, 2023
There was a problem hiding this comment.
@joshlf I don't believe this will work. The field expects GitHub names because the team repo uses GitHub names as the unique ID to identify people. This then gets resolved to a Zulip ID. However, you don't have a Zulip ID in joshlf.toml. You'll want to add that for this to work.
cc @JakobDegen and @RalfJung for awareness.
AFAIK this refers to the filenames in https://github.com/rust-lang/team/tree/master/people. They do not have to be the same as the github usernames. |
|
Okay, added my zulip-id as well; thanks for the pointer! |
rylev
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I've done this right since it doesn't actually look like Zulip uses usernames, but other folks seem to have used their GitHub usernames, so I'm doing the same 🤷♂️