-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom roles in website, beyond "Team leader" #1154
Conversation
Another possible application: team affiliation in https://www.rust-lang.org/governance/teams/leadership-council#leadership-council. "Lang team rep" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Overall it's a great change, and I'd be happy to merge except for one thing.
The current schema requires duplicating the member's name both in the team's members
array as well as part of role's members
array. Would it make sense to see if we can change the team members
array schema to allow for specifying roles inline to the member declaration?
Perhaps something like:
members = [
"rylev",
{ name = "dtolnay", role = "foo" }
]
According to the toml spec this should be fine, but I think maybe some toml parsers struggle with this syntax?
Updated to set roles inline in the team's existing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I think we can merge as is as the static API looks good (and that's the only thing that is somewhat tricky to change after the fact). However, I'd like to get your opinion on my comments on the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a great start! Let's merge this and we can adjust from here.
@dtolnay seems like there might be conflicts that need to be resolved first though.
In preparation for adding optional `roles` for members.
Rebased to fix superficial conflict with #1164 in src/validate.rs. |
I would like to render "Editor" below @JoelMarcey's entry in https://www.rust-lang.org/governance/teams/lang#spec, in the same location that others have "Team leader".
Source: https://blog.rust-lang.org/inside-rust/2023/11/15/spec-vision.html#specification-team
Output of
cargo run -- dump-website
for translations:Output of
cargo run -- static-api
under v1/teams/spec.json: