-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix team names and descriptions #127
Conversation
This would address #31. |
In #124 the new WG description was terminated with a period. Is this syntax preferred to no periods? |
I'm unsure if I need to ping people to review this. @pietroalbini |
cc @rust-lang/core |
I can do an initial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @LEARAX that I've been slow. I started this review some time back but I haven't come back to it. Will do soon, not forgotten
Looks like there's a bunch of merge conflicts, but this looks good to me modulo the few commits I left. Could you rebase it? |
Co-Authored-By: Niko Matsakis <[email protected]>
Co-Authored-By: Mark Rousskov <[email protected]>
Co-Authored-By: Mark Rousskov <[email protected]>
Never rebased before. Hopefully that worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you got the rebase almost right, just one file was added by accident. Everything else looks good, thanks!
By the way, I plan to squash this all into one commit when merging (or you can do so on your branch), I don't think we need a commit per file. |
@Mark-Simulacrum Probably not, there are quite a few commits. |
Thanks! |
Should this have closed #31 ? |
The grammar of team names and descriptions on the governance page of rust-lang.org is very inconsistent. This PR attempts to correct this, by changing each description to start with a present progressive verb, applying consistent capitalization rules, and ending most of the team names with either "working group" or "team" (moderator groups and observers were left as exceptions).