Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix team names and descriptions #127

Merged
merged 69 commits into from Feb 19, 2020
Merged

Fix team names and descriptions #127

merged 69 commits into from Feb 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented Sep 30, 2019

The grammar of team names and descriptions on the governance page of rust-lang.org is very inconsistent. This PR attempts to correct this, by changing each description to start with a present progressive verb, applying consistent capitalization rules, and ending most of the team names with either "working group" or "team" (moderator groups and observers were left as exceptions).

@ghost
Copy link
Author

ghost commented Sep 30, 2019

This would address #31.

@ghost
Copy link
Author

ghost commented Oct 1, 2019

In #124 the new WG description was terminated with a period. Is this syntax preferred to no periods?

@ghost
Copy link
Author

ghost commented Oct 11, 2019

I'm unsure if I need to ping people to review this. @pietroalbini

@pietroalbini
Copy link
Member

cc @rust-lang/core
I shouldn't be the one reviewing this.

@nikomatsakis nikomatsakis self-assigned this Oct 11, 2019
@nikomatsakis
Copy link
Contributor

I can do an initial review.

@vertexclique
Copy link
Member

vertexclique commented Nov 8, 2019

Please also take a look at this description for wg-localization. I changed this while I was adding myself to team in #180, but can be discarded. 49e9842

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @LEARAX that I've been slow. I started this review some time back but I haven't come back to it. Will do soon, not forgotten

teams/clippy.toml Outdated Show resolved Hide resolved
teams/community-content.toml Outdated Show resolved Hide resolved
@ghost ghost requested a review from nikomatsakis December 17, 2019 01:03
teams/release.toml Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

Looks like there's a bunch of merge conflicts, but this looks good to me modulo the few commits I left. Could you rebase it?

@ghost
Copy link
Author

ghost commented Feb 19, 2020

Never rebased before. Hopefully that worked.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you got the rebase almost right, just one file was added by accident. Everything else looks good, thanks!

teams/wg-async-await.toml Outdated Show resolved Hide resolved
@Mark-Simulacrum
Copy link
Member

By the way, I plan to squash this all into one commit when merging (or you can do so on your branch), I don't think we need a commit per file.

@ghost
Copy link
Author

ghost commented Feb 19, 2020

@Mark-Simulacrum Probably not, there are quite a few commits.

@Mark-Simulacrum Mark-Simulacrum merged commit 2922ca7 into rust-lang:master Feb 19, 2020
@Mark-Simulacrum
Copy link
Member

Thanks!

@RalfJung
Copy link
Member

Should this have closed #31 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants