Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf report for 2023-09-13 #4720

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

pnkfelix
Copy link
Member

No description provided.

3 Regressions, 2 Improvements, 5 Mixed; 2 of them in rollups
84 artifact comparisons made in total

[Full report here](https://github.com/rust-lang/rustc-perf/blob/master/triage/2023-09-13.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link seems to be broken - is there another target we should point to?

Copy link
Contributor

@mariannegoldin mariannegoldin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this submission. As soon as we can update the full report link target, I will approve and merge.

@pnkfelix
Copy link
Member Author

Thank you for this submission. As soon as we can update the full report link target, I will approve and merge.

The full report will be available once rust-lang/rustc-perf#1719 is merged. I’ll go check if there’s someone who can approve it (though I think there may be precedent to allow this notice to be merged to TWIR before the rustc-perf PR is merged…)

@mariannegoldin
Copy link
Contributor

@pnkfelix thanks for the update and the PR link! We might post the summary, and then once the PR goes through, add the link to the full report.

Copy link
Contributor

@mariannegoldin mariannegoldin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging with "pending" annotation for link - to be updated once the report is published.

@mariannegoldin mariannegoldin merged commit a346a31 into rust-lang:master Sep 14, 2023
1 check passed
@mariannegoldin
Copy link
Contributor

The link has been updated (pending annotation removed)

ijackson pushed a commit to ijackson/this-week-in-rust that referenced this pull request Oct 25, 2023
Context: rust-lang#4720 rust-lang#4721

Search functionality loading is blocking the front page from
loading for readers on mobile/tablet devices. This PR
temporarily disables search functionality until longer term
fix can be implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants