Use rfcbot style for FCPs in the prioritization agenda #1784
Conversation
|
I've found a pretty neat trick. Zulip as a de-ambiguator syntax when pinging users with the same name, it works by specifying the Zulip ID after the name, like so This greatly simplifies the process for us, as we don't have to query the name associated with the Zulip id. |
Urgau
force-pushed
the
compiler_fcp_details
branch
from
5883496 to
09612bf
Compare
Urgau
force-pushed
the
compiler_fcp_details
branch
from
09612bf to
189ae3d
Compare
|
Enabling mentions to remind team members checking their boxes in FCPs could have been a follow-up PR because it is unclear how it should work. However, for the sake of merging this change, I will approve this PR. For now it is disabled and will be discussed with T-compiler if and how that could work. Thanks @Urgau for suggesting this formatting for the FCPs.
|
|
Reverting my approval. I think this PR needs some more debugging |
Co-authored-by: apiraino <[email protected]>
|
@jackh726 we're done here, I think. When you have a sec feel free to have a look (and ofc leave a comment). thanks! |
templates/_issues_rfcbot.tt
Outdated
| {%- if issue.fcp_details is object %} | ||
| {{indent}}- {{issue.fcp_details.disposition}}: [{{issue.title}} ({{issue.repo_name}}#{{issue.number}})]({{issue.fcp_details.bot_tracking_comment_html_url}}) | ||
| {{indent}}{{indent}}-{% for reviewer in issue.fcp_details.pending_reviewers %} @{% if issue.fcp_details.should_mention %}{% else %}_{% endif %}**|{{reviewer.zulip_id}}**{%else%} no pending checkboxs{% endfor %} | ||
| {{indent}}{{indent}}-{% for concern in issue.fcp_details.concerns %} [{{concern.name}} (by {{concern.reviewer_login}})]({{concern.concern_url}}){%else%} no pending concerns{% endfor -%} |
There was a problem hiding this comment.
It might be nice to write something like concerns: ...
There was a problem hiding this comment.
It now looks like this (modulo the pings):
- Pending FCP requests (check your boxes!)
- merge: Add a new
--build-idflag to rustc (compiler-team#635)@Wesley Wiser@davidtwco@Aaron Hill@Vadim Petrochenkov- concerns: other-existing-options (by petrochenkov) option-name (by wesleywiser)
- merge: Retire the mailing list and make all decisions on zulip (compiler-team#649)
- no pending checkboxs
- concerns: automatic-sync (by compiler-errors) single-point-of-failure-via-stream-archival (by pnkfelix)
- merge: Add a new
This PR add the necessary information to replicate the rfcbot style when showing FCPs and uses it in the prioritization agenda.
One thing at isn't perfect is that we are using the Github login and not the Zulip login, using the Zulip username would require accessing the team database which I didn't wanted to do yet but could be done as a follow up PR.(fixed, #1784 (comment))r? @apiraino
They would now look like this (modulo the mentions).
Full example here.--build-idflag to rustc (compiler-team#635)@wesleywiser@davidtwco@Aaron1011@petrochenkov