PR assignment based on work queue availability (take #2) #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a version of rust-lang#1786 that fixes the two following bugs: There were 2 bugs: 1. the initial migration wasn't formatted correctly and the new schema changes weren't applied 2. The SELECT to find a reviewer would return wrong results when a team member had NULL in the table `review_prefs.max_assigned_prs`
apiraino
commented
Apr 16, 2024
Comment on lines
+335
to
+341
| CREATE EXTENSION IF NOT EXISTS intarray;", | ||
| " | ||
| CREATE UNIQUE INDEX IF NOT EXISTS review_prefs_user_id ON review_prefs(user_id); | ||
| ", | ||
| " | ||
| ALTER TABLE review_prefs ADD COLUMN IF NOT EXISTS max_assigned_prs INTEGER DEFAULT NULL; | ||
| ", |
There was a problem hiding this comment.
The migration should now be correctly formatted.
Adding the clause IF NOT EXISTS should address the concern addressed in this comment about re-running them.
cc: @Mark-Simulacrum
apiraino
commented
Apr 16, 2024
| FROM review_prefs r | ||
| JOIN users ON users.user_id = r.user_id | ||
| WHERE username = $1 | ||
| AND ( CARDINALITY(r.assigned_prs) < max_assigned_prs OR max_assigned_prs IS NULL );"; |
There was a problem hiding this comment.
The old version of this SQL query (here) would fail to find a reviewer if the candidate had max_assignment_prs was NULL
apiraino
commented
Apr 16, 2024
jackh726
approved these changes
Apr 16, 2024
|
Okay, let's try this again. |
|
For sure if this is still problematic, we need to consider splitting this up. |
This was referenced Apr 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a version of #1786 that fixes the two following bugs:
Fixes 2 bugs:
the initial migration wasn't formatted correctly and the new schema changes weren't applied
The SELECT to find a reviewer would return wrong results when a team member had NULL in the table
review_prefs.max_assigned_prsr? @jackh726