Use nostr-ots without default feautres, avoid ureq dep #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By providing a Stamper trait impl with the http library already in the dep tree
yukibtc
force-pushed
the
master
branch
2 times, most recently
from
927e34b
to
5a88ee8
Compare
yukibtc
force-pushed
the
master
branch
2 times, most recently
from
5db3108
to
ddd3d1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By providing a Stamper trait impl with the http library already in the dep tree
Description
I didn't like to add another HTTP dep to a library that already has one, with RCasatta/nostr-ots#8 is possible to provide a Stamper trait to perform the needed HTTP request
Notes to the reviewers
The code is still a draft, but wanted to share the idea to receive early feedback
Changelog notice
Checklists
All Submissions:
make precommitbefore committing