TryFrom implementation for ExceptionVector #506
Conversation
|
Thank you for your contribution!
Let's use a simple error type that wraps the invalid u8. Feel free to use x86_64/src/instructions/tlb.rs Lines 78 to 88 in 323d46c |
mrjbom
force-pushed
the
TryFrom_for_ExceptionVector
branch
2 times, most recently
from
1a3495b
to
951cf44
Compare
|
Made Error as enum for more details |
mrjbom
force-pushed
the
TryFrom_for_ExceptionVector
branch
from
951cf44
to
587b2fa
Compare
src/structures/idt.rs
Outdated
| impl fmt::Display for InvalidExceptionVectorNumber { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| match self { | ||
| InvalidExceptionVectorNumber::IsCoprocessorSegmentOverrun(exception_vector_number) => { | ||
| write!(f, "{exception_vector_number} cannot be a valid exception vector number because the Coprocessor Segment Overrun exception is handled as part of the General Protection Fault") | ||
| } | ||
| InvalidExceptionVectorNumber::Reserved(exception_vector_number) => { | ||
| write!(f, "{exception_vector_number} cannot be a valid exception vector number because it is reserved") | ||
| } | ||
| InvalidExceptionVectorNumber::NotException(exception_vector_number) => { | ||
| write!(f, "{exception_vector_number} cannot be a valid exception vector number because only the first 32 numbers can be exception numbers") | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is certainly a matter of opinion, but the error messages seem too lengthy to me. Let's just print "{} is not a valid exception vector" in all cases and let's also use a struct instead of an enum. It shouldn't be difficult for the user to figure out what went wrong in each case.
mrjbom
force-pushed
the
TryFrom_for_ExceptionVector
branch
from
587b2fa
to
bc9441d
Compare
Freax13
force-pushed
the
TryFrom_for_ExceptionVector
branch
from
bc9441d
to
6e0652f
Compare
|
I rebased this PR onto the lastest master branch to fix CI. |
There is currently no way to create an instance of idt::ExceptionVector having an interrupt number. At the same time it would be convenient for the user to use this enum to handle interrupts.
As for the implementation, I couldn't think of what type of error it should return.