ci: Enalbe tests with no platform specified
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimePrinciple
requested review from
andreeaflorescu,
lauralt,
sameo,
roypat and
ShadowCurse
as code owners
|
I'm deeply sorry about breaking our CI tests 😭 |
roypat
previously approved these changes
Oct 3, 2024
And |
Ah true. Still, out of all the tests it could've hit, these were definitely the least important ones, so don't beat yourself up over it! It's just as much our fault for not noticing it during review |
lauralt
reviewed
Oct 4, 2024
lauralt
reviewed
Oct 4, 2024
TimePrinciple
force-pushed
the
enable-no-platform-tests
branch
from
bbe1dec to
77e4072
Compare
TimePrinciple
force-pushed
the
enable-no-platform-tests
branch
2 times, most recently
from
afc44dd to
89defc1
Compare
After `.platform` mechanism was introduced in rust-vmm#159, it silently filters out tests with no `platform` specified. Enable them to execute by adding `platform is not None` predicate preceeds allowlist check. Signed-off-by: Ruoqing He <[email protected]>
TimePrinciple
force-pushed
the
enable-no-platform-tests
branch
from
89defc1 to
aed4b69
Compare
lauralt
approved these changes
Oct 6, 2024
roypat
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
After
.platformmechanism was introduced in #159, it silently filtersout tests with no
platformspecified. Enable them to execute by addingplatform is not Nonepredicate preceeds allowlist check.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.