Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of the vm-memory crate #1
Initial implementation of the vm-memory crate #1
Changes from all commits
a2f4b47
76f2c2e
cfa9f21
86083b1
ed5ea88
c363375
1c49e8c
24fdfa4
2508c1d
43839ae
c91e77b
0bb72db
69901fa
724fdc0
2577c52
650026b
b15b673
0b41800
6e667dd
2a54652
30f386b
539287d
f7205c4
50a0bfb
aeaa14a
b4ad2fc
609a6ca
b2e7ef5
92b11f0
7bcb08d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we want to highlight the fact that
GuestMemoryMmap
is theGuestMemory
implementation for an mmap'ed volatile memory backend.That's our top level VM memory interface for the mmap backend, and we should highlight that.
I'm thinking about adding a sub-section to this section with really simple examples on how to use
GuestMemoryMmap
. I'll do so as a follow-up PR.