Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: Increase the maximum word limit for commit message body #58

Merged

Conversation

Tim-Zhang
Copy link
Contributor

The original limit 72 was too strict to follow.

The original limit 72 was too strict to follow.

Signed-off-by: Tim Zhang <[email protected]>
Copy link
Contributor

@qwandor qwandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapping at 72 columns is fairly standard for git commit messages, it doesn't seem like a big issue to me. Is there something you can't wrap?

@jalil-salame
Copy link
Contributor

Wrapping at 72 columns is fairly standard for git commit messages, it doesn't seem like a big issue to me. Is there something you can't wrap?

I usually come across the limit (in other repos) when adding a link for context as they easily go over 72 characters.

@jalil-salame
Copy link
Contributor

@Tim-Zhang Tim-Zhang merged commit 9281018 into rust-vsock:master Dec 25, 2024
3 checks passed
@Tim-Zhang Tim-Zhang deleted the gh-increase-limit-of-commit-body branch December 25, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants