Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Exit when the user presses Escape #1657

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

MarijnS95
Copy link
Member

No description provided.

@kchibisov
Copy link
Member

Hm, maybe set it in title as well, since I think it's only relevant on stacking wms where user doesn't know the hotkey to close a window.

@MarijnS95
Copy link
Member Author

You mean the window title? Or enable the close button in the window?

I won't see those because I don't use window borders/decorations in sway.

@kchibisov
Copy link
Member

You mean the window title?

Yes, window title.

I won't see those because I don't use window borders/decorations in sway.

You should know how to close any window on sway with the hotkey though.

@MarijnS95
Copy link
Member Author

You should know how to close any window on sway with the hotkey though.

Sure, but I've grown accustomed to graphics (test) apps supporting Escape specifically.

@MarijnS95 MarijnS95 force-pushed the examples-exit-escape branch from 4cc696a to 98b4cd4 Compare January 4, 2024 23:06
@MarijnS95 MarijnS95 force-pushed the examples-exit-escape branch from 98b4cd4 to 854882d Compare January 4, 2024 23:07
@MarijnS95 MarijnS95 requested a review from kchibisov January 4, 2024 23:07
@kchibisov kchibisov merged commit 719671f into master Jan 5, 2024
43 checks passed
@MarijnS95 MarijnS95 deleted the examples-exit-escape branch January 5, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants