Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change surface to be Send #1662

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

vially
Copy link
Contributor

@vially vially commented Dec 27, 2023

As it was recently discussed on matrix, it turns out the GL Surface can also be made Send (similar to the Context, which is Send already).

Warning

I've only tested the example program on Wayland, so there's a good chance it might not work on other platforms (and I don't have an easy way to test it either).

Also, I'm just getting started with Rust, so the example code is definitely not very idiomatic, and most likely also incorrect, so please review it carefully. However, I don't mind iterating on it to get it in a better shape, if someone is willing to guide me in the right direction.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@vially vially changed the title egl: change surface to be Send Change surface to be Send Dec 27, 2023
@vially vially marked this pull request as draft December 28, 2023 00:13
@vially vially force-pushed the vh/make-surface-send branch from b496dce to 2b3feaf Compare December 28, 2023 00:31
@vially vially marked this pull request as ready for review December 28, 2023 00:32
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into example latter.

CHANGELOG.md Outdated Show resolved Hide resolved
@kchibisov
Copy link
Member

macOS tested.
X11 tested.

@kchibisov
Copy link
Member

Windows tested.

@kchibisov kchibisov merged commit 7c93de9 into rust-windowing:master Feb 12, 2024
43 checks passed
@kchibisov
Copy link
Member

Pushed 0.31.3 with that, let's see how it survives.

@vially vially deleted the vh/make-surface-send branch February 12, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants