Glutin version 0.31.3

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Unreleased
 
+# Version 0.31.3
+
+- Change `Surface` to be `Send`. This makes it consistent with the context, so now they are both `Send` but not `Sync`.
+
 # Version 0.31.2
 
 - Fixed EGL not setting context version with EGL versions before 1.5 and missing context ext.

README.md

@@ -7,7 +7,7 @@ A low-level library for OpenGL context creation.
 
 ```toml
 [dependencies]
-glutin = "0.31.2"
+glutin = "0.31.3"
 ```
 
 ## [Documentation](https://docs.rs/glutin)

glutin/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "glutin"
-version = "0.31.2"
+version = "0.31.3"
 authors = ["Kirill Chibisov <[email protected]>"]
 description = "Cross-platform OpenGL context provider."
 keywords = ["windowing", "opengl", "egl"]

glutin/src/api/cgl/surface.rs

@@ -81,7 +81,7 @@ impl Display {
             config: config.clone(),
             ns_view,
             ns_window,
-            _nosendsync: PhantomData,
+            _nosync: PhantomData,
             _ty: PhantomData,
         };
         Ok(surface)
@@ -94,10 +94,13 @@ pub struct Surface<T: SurfaceTypeTrait> {
     config: Config,
     pub(crate) ns_view: MainThreadBound<Id<NSView>>,
     ns_window: MainThreadBound<Id<NSWindow>>,
-    _nosendsync: PhantomData<*const std::ffi::c_void>,
+    _nosync: PhantomData<*const std::ffi::c_void>,
     _ty: PhantomData<T>,
 }
 
+// Impl only `Send` for Surface.
+unsafe impl<T: SurfaceTypeTrait> Send for Surface<T> {}
+
 impl<T: SurfaceTypeTrait> GlSurface<T> for Surface<T> {
     type Context = PossiblyCurrentContext;
     type SurfaceType = T;

glutin/src/api/egl/surface.rs

@@ -252,6 +252,9 @@ pub struct Surface<T: SurfaceTypeTrait> {
     _ty: PhantomData<T>,
 }
 
+// Impl only `Send` for Surface.
+unsafe impl<T: SurfaceTypeTrait> Send for Surface<T> {}
+
 impl<T: SurfaceTypeTrait> Surface<T> {
     /// Swaps the underlying back buffers when the surface is not single
     /// buffered and pass the [`Rect`] information to the system

glutin/src/api/glx/surface.rs

@@ -159,6 +159,9 @@ pub struct Surface<T: SurfaceTypeTrait> {
     _ty: PhantomData<T>,
 }
 
+// Impl only `Send` for Surface.
+unsafe impl<T: SurfaceTypeTrait> Send for Surface<T> {}
+
 impl<T: SurfaceTypeTrait> Surface<T> {
     /// # Safety
     ///

glutin/src/api/wgl/surface.rs

@@ -81,6 +81,9 @@ pub struct Surface<T: SurfaceTypeTrait> {
     _ty: PhantomData<T>,
 }
 
+// Impl only `Send` for Surface.
+unsafe impl<T: SurfaceTypeTrait> Send for Surface<T> {}
+
 impl<T: SurfaceTypeTrait> Drop for Surface<T> {
     fn drop(&mut self) {
         unsafe {

glutin/src/surface.rs

@@ -262,10 +262,11 @@ pub enum SurfaceType {
 
 /// The GL surface that is used for rendering.
 ///
-/// The GL surface is not thread safe, it can neither be [`Send`] nor [`Sync`],
-/// so it should be created on the thread it'll be used to render.
+/// Similar to the context, the GL surface is [`Send`] but not [`Sync`]. This
+/// means it could be sent to a different thread as long as it is not current on
+/// another thread.
 ///
-/// ```compile_fail
+/// ```no_run
 /// fn test_send<T: Send>() {}
 /// test_send::<glutin::surface::Surface<glutin::surface::WindowSurface>>();
 /// ```