Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update objc2 crates #1673

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Update objc2 crates #1673

merged 2 commits into from
Apr 18, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Apr 18, 2024

Changes relevant to glutin:

  • icrate has been deprecated in favour of separate crates per framework, in our case objc2-foundation and objc2-app-kit.
  • Moved MainThreadMarker::run_on_main to free-standing function run_on_main.
  • Changed how features work, this should result in less code that needs to be compiled.

See rust-windowing/winit#3634 for the Winit change.

  • Tested on all platforms changed

madsmtm added 2 commits April 18, 2024 17:49
Changes relevant to glutin:
- `icrate` has been deprecated in favour of separate crates per
  framework, in our case `objc2-foundation` and `objc2-app-kit`.
- Moved `MainThreadMarker::run_on_main` to free-standing function
  `run_on_main`.
- Changed how features work, this should result in less code that needs
  to be compiled.

See rust-windowing/winit#3634 for the Winit
change.
@kchibisov kchibisov merged commit 08e1000 into master Apr 18, 2024
43 checks passed
@madsmtm madsmtm deleted the madsmtm/update-objc2 branch April 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants