Upgrade winit 0.29.2 → 0.30.0
#1678
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
ErichDonGubler
force-pushed
the
winit-0.30
branch
3 times, most recently
from
a01c46a to
bf431b9
Compare
|
The changes in Both PRs are refactoring the examples in a completely different way though, and I lean towards what you're doing here by loosing less code and maintaining more of the original architecture. But it remains hard to review both PRs as they (inevitably) move a lot of code around in the diff. |
|
@MarijnS95: I strongly recommend going through these changes commit-by-commit, rather than looking through the overall diff. I've striven to make each as small as possible. |
|
This PR examples look better indeed, do you want to maybe merge your PR against mine? So mine goes with your examples Sounds good? :-) |
|
@ErichDonGubler since you already expressed that you didn't expect this PR to get merged in favour of the other one, I didn't give this PR (nor the other one) more than a quick scroll-through. Since your PR history is nice and readable, I propose to integrate that in one of the two branches. |
|
@ErichDonGubler Do you want me to just copy your examples straight into my PR or do you want to maybe rebase this PR on mine with my core changes and your examples so we can merge it into mine? |
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
winit-0.30
branch
2 times, most recently
from
6501830 to
6fa9330
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
winit-0.30
branch
from
5f1a241 to
bd053c1
Compare
|
@marc2332: I'll leave the choice up to you whether you want to force-push this branch's history onto yours at #1675, or just abandon it and get a fresh round of @MarijnS95's feedback here. I'm willing to handle feedback if it's left open here, in case that helps. 🙂 |
Co-Authored-By: marc2332 <[email protected]> Co-Authored-By: Kirill Chibisov <[email protected]> Co-Authored-By: Marijn Suijten <[email protected]>
Not sure why you did that, I already had his changes in my PR 🤔 |
When testing the `glutin` example on Android, after suspending and resuming the app no triangle appears. As it turns out the `winit 0.30` bump in rust-windowing#1678 never reuses the `not_current_context` that was set apart in `suspend()`, but creates a new one, without re-running initialization code such as creating the `Renderer`. Partially restore original code before the `winit 0.30` bump, which never created a context in `resume()` because it was already available before the loop started (and moved back in place in `suspend()`). Note also that more initialization code that now (unnecessarily) lives in `resume()` used to be outside of the loop.
When testing the `glutin` example on Android, after suspending and resuming the app no triangle appears. As it turns out the `winit 0.30` bump in rust-windowing#1678 never reuses the `not_current_context` that was set apart in `suspend()`, but creates a new one, without re-running initialization code such as creating the `Renderer`. Partially restore original code before the `winit 0.30` bump, which never created a context in `resume()` because it was already available before the loop started (and moved back in place in `suspend()`). Note also that more initialization code that now (unnecessarily) lives in `resume()` used to be outside of the loop.
When testing the `glutin` example on Android, after suspending and resuming the app no triangle appears. As it turns out the `winit 0.30` bump in rust-windowing#1678 never reuses the `not_current_context` that was set apart in `suspend()`, but creates a new one, without re-running initialization code such as creating the `Renderer`. Partially restore original code before the `winit 0.30` bump, which never created a context in `resume()` because it was already available before the loop started (and moved back in place in `suspend()`). Note also that more initialization code that now (unnecessarily) lives in `resume()` used to be outside of the loop.
When testing the `glutin` example on Android, after suspending and resuming the app no triangle appears. As it turns out the `winit 0.30` bump in #1678 never reuses the `not_current_context` that was set apart in `suspend()`, but creates a new one, without re-running initialization code such as creating the `Renderer`. Partially restore original code before the `winit 0.30` bump, which never created a context in `resume()` because it was already available before the loop started (and moved back in place in `suspend()`). Note also that more initialization code that now (unnecessarily) lives in `resume()` used to be outside of the loop.
When testing the `glutin` example on Android, after suspending and resuming the app no triangle appears. As it turns out the `winit 0.30` bump in #1678 never reuses the `not_current_context` that was set apart in `suspend()`, but creates a new one, without re-running initialization code such as creating the `Renderer`. Partially restore original code before the `winit 0.30` bump, which never created a context in `resume()` because it was already available before the loop started (and moved back in place in `suspend()`). Note also that more initialization code that now (unnecessarily) lives in `resume()` used to be outside of the loop.
When testing the `glutin` example on Android, after suspending and resuming the app no triangle appears. As it turns out the `winit 0.30` bump in #1678 never reuses the `not_current_context` that was set apart in `suspend()`, but creates a new one, without re-running initialization code such as creating the `Renderer`. Partially restore original code before the `winit 0.30` bump, which never created a context in `resume()` because it was already available before the loop started (and moved back in place in `suspend()`). Note also that more initialization code that now (unnecessarily) lives in `resume()` used to be outside of the loop.
CHANGELOG.mdif knowledge of this change could be valuable to usersResolves #1674.