Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update drm, nix, and criterion dependencies #163

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update drm, nix, and criterion dependencies #163

merged 1 commit into from
Oct 13, 2023

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Oct 13, 2023

No description provided.

@ids1024 ids1024 requested a review from john01dav as a code owner October 13, 2023 05:16
@ids1024 ids1024 force-pushed the update-deps branch 2 times, most recently from cf31407 to 98dc43a Compare October 13, 2023 05:30
@ids1024
Copy link
Member Author

ids1024 commented Oct 13, 2023

It seems clap, used by criterion, wants Rust 1.70.0.

@notgull
Copy link
Member

notgull commented Oct 13, 2023

Let's pin the version of criterion for now, it's only a dev dependency.

notgull
notgull approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ids1024 ids1024 merged commit ea81ff2 into master Oct 13, 2023
39 checks passed
@ids1024 ids1024 deleted the update-deps branch October 13, 2023 20:54
@notgull notgull mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

@john01dav john01dav Awaiting requested review from john01dav

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ids1024 @notgull