-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wayland-client to 0.30 #2128
Comments
wayland-client 0.30 isn't even released. And it'll take time to update things, since first of all sctk should be updated. But yeah, I'm long aware of this issue, and I think I saw it only once in the wild in like 3 years. |
I've been hacking on a wayland compositor and I saw it immediately when trying to start alacritty because wayland-client in alacritty is not up to date with the upstream wayland protocol. Here is the wayland-client 0.30 issue: Smithay/wayland-rs#431 |
You can ask @vberger for wayland-protocols bump for old wayland-client. Will like solve the issue for a few month or so while migrating to wayland-client v0.30.0 is happening. |
As you say but either way it would take many days for a fixed alacritty to be released. For now I've simply removed the more obscure shm formats from my code. |
I mean, it'll take like a week at max, since alacritty is in a release process and waiting for winit version bump. |
@vberger Could you release wayland-client |
Technically, this update would be a breaking change (as it is adding new variants to an enum exposed in the rust API), however I think we can reasonably assume that no client using wayland-rs is exhaustively matching on that enum. So yes, I should be able to release 0.29.3 with the protocol update in a few hours. |
|
Thanks |
Why did you close this? |
Well, I can reopen this issue to track update to new wayland-client, but the whole purpose of the original issue was to update to wayland.xml winit is using, since you've opened issues on alacritty and winit trackers in near the same time. |
The |
I'm working on it, but it'll take time... More likely weeks/month, given that even if I write an update it'll take some time to verify that everything is working as before. Be aware that xml-rs wayland-protocols is a |
I appreciate it - thanks very much for your work here! I do worry a bit about build-time dependencies, too: after all, they run on my computer when I'm doing development. |
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2128.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2128.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2128.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2128.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2128.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2164. Fixes rust-windowing#2128. Fixes rust-windowing#1760. Fixes rust-windowing#725.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2164. Fixes rust-windowing#2128. Fixes rust-windowing#1760. Fixes rust-windowing#725.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2164. Fixes rust-windowing#2128. Fixes rust-windowing#1760. Fixes rust-windowing#725.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2164. Fixes rust-windowing#2128. Fixes rust-windowing#1760. Fixes rust-windowing#725.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2164. Fixes rust-windowing#2128. Fixes rust-windowing#1760. Fixes rust-windowing#725.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2164. Fixes rust-windowing#2128. Fixes rust-windowing#1760. Fixes rust-windowing#725.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes rust-windowing#2560. Fixes rust-windowing#2164. Fixes rust-windowing#2128. Fixes rust-windowing#1760. Fixes rust-windowing#725.
This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol. Fixes #2560. Fixes #2164. Fixes #2128. Fixes #1760. Fixes #725.
wayland-client below 0.30 is fundamentally broken in that updating your compositor can cause wayland-client applications to abort immediately on start. This is because wayland-client below 0.30 cannot handle unknown shm formats but compositors are allowed to add new formats at any time.
The text was updated successfully, but these errors were encountered: