Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wayland-rs to 0.30.0 #2676

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Update wayland-rs to 0.30.0 #2676

merged 1 commit into from
Apr 18, 2023
+3,440 −3,383

Conversation

kchibisov
Copy link
Member

@kchibisov kchibisov commented Feb 6, 2023 •
edited
Loading

This update rewrites the winit's Wayland backend using new wayland-rs 0.30 API. This fixes long standing issue with the forward compatibility of the wayland backend, meaning that future updates to the wayland protocol won't break rust code anymore. like it was before when adding new shm/enum variants into the protocol.

Fixes #2560.
Fixes #2164.
Fixes #2128.
Fixes #1760.
Fixes #725.

--

TBD:

  • Fractional scaling
  • Client side decorations
  • Testing on compositors other than sway
  • SCTK release
  • CHANGELOG update
  • Keyboard sometimes blast repeats

@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch from ad7d81c to 867136b Compare February 6, 2023 17:56
@madsmtm madsmtm added DS - wayland S - maintenance Repaying technical debt labels Feb 7, 2023
@kchibisov kchibisov mentioned this pull request Feb 15, 2023
Closed
2 tasks
@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch 3 times, most recently from 0500458 to fabe202 Compare February 25, 2023 19:25
@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch from fabe202 to fb6af67 Compare March 6, 2023 08:07
@kchibisov kchibisov marked this pull request as ready for review March 6, 2023 08:07
@kchibisov
Copy link
Member Author

Besides SCTK release and sctk-adwaita, everything should be in place now, including normal CSD decorations.

picture

The other part that is left is testing, since it was tested mostly on sway.

@kchibisov kchibisov mentioned this pull request Mar 7, 2023
Merged
@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch 2 times, most recently from b49a40f to 598142a Compare March 7, 2023 20:05
@kchibisov
Copy link
Member Author

The sctk-adwaita decorations are back now as well. So only waiting for upstream patches to propagate properly.

@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch 2 times, most recently from 45ceaaf to 73d03a9 Compare March 8, 2023 16:59
@eddyb eddyb mentioned this pull request Mar 21, 2023
Merged
@kchibisov kchibisov mentioned this pull request Mar 31, 2023
Closed
@torokati44
Copy link
Contributor

torokati44 commented Mar 31, 2023 •
edited
Loading

Can confirm this will fix #2753!

EDIT: In fact, the first commit, fe73b10, is enough in itself for it to be fixed.

@kchibisov
Copy link
Member Author

EDIT: In fact, the first commit, fe73b10, is enough in itself for it to be fixed.

you know, it's +3K -3K commit in the end, but I know that resize on this branch is sane.

@torokati44
Copy link
Contributor

you know, it's +3K -3K commit in the end

Well, yeah, haha... 😅 It was just easier to test the first commit in itself with the current set of dependencies - with the final commit of the PR I had issues related to AdwaitaFrame and SCTK.

@kchibisov
Copy link
Member Author

Well, yeah, haha... sweat_smile It was just easier to test the first commit in itself with the current set of dependencies - with the final commit of the PR I had issues related to AdwaitaFrame and SCTK.

Like it doesn't build or something like that? That could be the case, given that I haven't update the branch for a while.

@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch from 73d03a9 to a2a1259 Compare April 1, 2023 19:06
@kchibisov
Copy link
Member Author

It should build now for what it matters.

@torokati44
Copy link
Contributor

Yes, it works with the latest commit now, thanks!

@yavko yavko mentioned this pull request Apr 6, 2023
Open
@jlkDE jlkDE mentioned this pull request Apr 7, 2023
Closed
@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch from f9fbc80 to 7119658 Compare April 14, 2023 05:45
@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch 3 times, most recently from 101216b to f42112c Compare April 18, 2023 21:26
@kchibisov
Update wayland-rs to 0.30.0
a339c1c 
This update rewrites the winit's Wayland backend using new wayland-rs
0.30 API. This fixes long standing issue with the forward compatibility
of the wayland backend, meaning that future updates to the wayland
protocol won't break rust code anymore. like it was before when adding
new shm/enum variants into the protocol.

Fixes rust-windowing#2560.
Fixes rust-windowing#2164.
Fixes rust-windowing#2128.
Fixes rust-windowing#1760.
Fixes rust-windowing#725.
@kchibisov kchibisov force-pushed the update-wayland-rs-0.30 branch from f42112c to a339c1c Compare April 18, 2023 21:29
@kchibisov kchibisov merged commit 2496098 into rust-windowing:master Apr 18, 2023
@torokati44 torokati44 mentioned this pull request Apr 19, 2023
Open
@citorva citorva mentioned this pull request Jul 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rib rib rib left review comments

@halotroop2288 halotroop2288 halotroop2288 approved these changes

Assignees
No one assigned
Labels
DS - wayland S - maintenance Repaying technical debt
Milestone
No milestone
5 participants
@kchibisov @torokati44 @rib @halotroop2288 @madsmtm