-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write migrations for each release #3477
Comments
I think the changelog is the place to put migrations, as they're only really relevant for that particular release, and only relevant when you're upgrading. |
Maybe we should just make CHANGELOG per release? Like my main issue is that I don't really want a giant file with all of that, since it'll only grow over time. |
I think it's fine that it grows, that's how changelogs are, and it is kinda convenient to be able to go back in history in it. It's like a poor mans |
The issue starts when you include code snippets there. oneliners are fine, so that's why I'd rather maintain separate entries for migrations itself. |
I would also prefer one big file. |
I don't see why putting separate changelog for each release won't work as in the current CHANGELOG.md represents the next release, the rest is just stashed inside the Like I don't want to maintain 10K lines of markdown. |
We discussed this in today's meeting, the conclusion was to split changelog per major version into files and include migrations into each file. Docs.rs integration would also work well with this. I've assigned myself on the issue, as I'll attempt to put up a PR for this. Unresolved is whether or not to backport this to v0.29, I guess it depends on whatever @kchibisov thinks is easiest. |
Will close this once we have written the migrations for 0.30 |
We should write migrations between releases showing who to port certain code and probably linking to discussions why certain change were made in the first.
Then e.g. rustdoc/CHANGELOG could link to relevant entries for migrations.
An example for such migration is like that:
#3447 (comment)
The migrations should probably in
migrations
directory with formatmigration_release.md
(only for major releases with breaking changes).The text was updated successfully, but these errors were encountered: