Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write migration instructions for v0.30 #3612

Closed
wants to merge 1 commit into from

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Mar 28, 2024

Fixes #3477.

I've not yet finished the issue description for the feedback issue, my WIP on that is below, will update this description later.

# Feedback on migration to trait-based design

We're interested in [...]

See https://github.com/rust-windowing/winit/issues/3432 for more details.

@madsmtm madsmtm added S - docs Awareness, docs, examples, etc. C - in progress Implementation is proceeding smoothly labels Mar 28, 2024
@madsmtm madsmtm added this to the Version 0.30.0 milestone Mar 28, 2024
@madsmtm madsmtm changed the title Write migration instructions for v0.30 Write migration instructions for v0.30 Mar 28, 2024
@kchibisov
Copy link
Member

I was actually doing the same based on my PR which made the sections, you can look into how it was done

#3614

Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would prefer more sub-headers and separating the migration from the regular changelog entries but still keep it in the same file.

@kchibisov
Copy link
Member

ping @madsmtm @daxpedda with the context of #3614

I can finish myself, since anything that is not overly verbose/informal is fine.

@madsmtm
Copy link
Member Author

madsmtm commented Apr 12, 2024

I've merged this into #3614.

@madsmtm madsmtm closed this Apr 12, 2024
@madsmtm madsmtm deleted the madsmtm/migration-instructions branch April 12, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - in progress Implementation is proceeding smoothly S - docs Awareness, docs, examples, etc.
Development

Successfully merging this pull request may close these issues.

Write migrations for each release
3 participants