Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy fixes #2011

Merged
merged 13 commits into from
Aug 30, 2021
Merged

Clippy fixes #2011

merged 13 commits into from
Aug 30, 2021

Conversation

filnet
Copy link
Contributor

@filnet filnet commented Aug 23, 2021 •
edited
Loading

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

madsmtm
madsmtm reviewed Aug 23, 2021
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉!

Can you also fix the two normal check warnings with file_drop_handler and broken_intra_doc_links? They can be seen at the bottom of this page.

@maroider maroider added C - waiting on maintainer A maintainer must review this code S - maintenance Repaying technical debt labels Aug 23, 2021
@filnet filnet force-pushed the clippy_fixes branch 3 times, most recently from a19fc33 to 7b36070 Compare August 24, 2021 13:35
madsmtm
madsmtm requested changes Aug 24, 2021
View reviewed changes
src/event.rs Outdated Show resolved Hide resolved
maroider
maroider reviewed Aug 24, 2021
View reviewed changes
Cargo.toml Show resolved Hide resolved
src/platform_impl/windows/dark_mode.rs Show resolved Hide resolved
src/window.rs Outdated Show resolved Hide resolved
@maroider maroider requested a review from msiglreith August 28, 2021 19:52
@maroider maroider mentioned this pull request Aug 28, 2021
Closed
7 tasks
msiglreith
msiglreith reviewed Aug 28, 2021
View reviewed changes
src/platform_impl/windows/event_loop.rs Outdated
@@ -938,7 +938,7 @@ unsafe fn public_window_callback_inner<T: 'static>(
winuser::MonitorFromRect(&new_rect, winuser::MONITOR_DEFAULTTONULL);
match fullscreen {
Fullscreen::Borderless(ref mut fullscreen_monitor) => {
if new_monitor != ptr::null_mut()
if new_monitor.is_null()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this inverts the logic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

ArturKovacs
ArturKovacs approved these changes Aug 28, 2021
View reviewed changes
Copy link
Contributor

@ArturKovacs ArturKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than what msiglreith pointed out, this looks good to me.

msiglreith
msiglreith approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I guess we had enough eyes on this to merge it in!

@msiglreith msiglreith merged commit 1b3b82a into rust-windowing:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maroider maroider maroider approved these changes

@madsmtm madsmtm madsmtm approved these changes

@ArturKovacs ArturKovacs ArturKovacs approved these changes

@msiglreith msiglreith msiglreith approved these changes

Assignees
No one assigned
Labels
C - waiting on maintainer A maintainer must review this code S - maintenance Repaying technical debt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filnet @msiglreith @ArturKovacs @madsmtm @maroider