Increase test coverage for generic modules #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, it's about ready now. Baby steps. |
|
Besides that it doesn't build, could we have tests in the file they are testing? |
daxpedda
approved these changes
Aug 4, 2023
- Rename attr_coverage functions to be more descriptive - Move tests to the file that they test - Fix build errors caused by changes to the Event enum Signed-off-by: John Nunley <[email protected]>
kchibisov
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersThis PR adds test cases for the higher-level modules of
winit(dpi, event, etc). The goal here is to have 100% test coverage forwinit, or at least as high as we can reasonably reach.WIP