Port to windows-sys v0.48.0 #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kchibisov
requested changes
Jun 3, 2023
src/platform_impl/windows/util.rs
Outdated
| @@ -149,6 +149,9 @@ pub fn is_minimized(window: HWND) -> bool { | |||
| unsafe { IsIconic(window) != false.into() } | |||
| } | |||
|
|
|||
| #[allow(clippy::upper_case_acronyms)] | |||
| pub type HINSTANCE = isize; | |||
There was a problem hiding this comment.
It was said that HMODULE is the same as HINSTANCE nowadays, the difference was only on 16bit windows, so we likely should use HMODULE.
https://learn.microsoft.com/en-us/windows/win32/winprog/windows-data-types
kchibisov
reviewed
Jun 3, 2023
| @@ -60,6 +60,7 @@ And please only add new entries to the top of this list, right below the `# Unre | |||
| - On Web, fix pointer button events not being processed when a buttons is already pressed. | |||
| - **Breaking:** Updated `bitflags` crate version to `2`, which changes the API on exposed types. | |||
| - On Web, handle coalesced pointer events, which increases the resolution of pointer inputs. | |||
| - On Windows, port to `windows-sys` version 0.48.0. | |||
There was a problem hiding this comment.
I don't think it's meaningful to users. Though the changelog entries have conflicts.
There was a problem hiding this comment.
Disagree; windows-sys version churn has been a frequent enough problem that's been resolved as of version 0.48.0 (at least for the time being). Knowledge that we are using this new version may be valuable to users trying to avoid windows-sys version churn.
kchibisov
approved these changes
Jun 3, 2023
msiglreith
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersShould fix the
cargo denyerrors we've been getting on #2812