Improve thread safety #2985
Merged
Improve thread safety #2985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
B - bug
madsmtm
requested review from
jackpot51,
msiglreith,
daxpedda and
kchibisov
as code owners
madsmtm
commented
Jul 29, 2023
madsmtm
force-pushed
the
improve-thread-safety
branch
2 times, most recently
from
163afba to
6644770
Compare
daxpedda
approved these changes
Aug 4, 2023
daxpedda
reviewed
Aug 4, 2023
daxpedda
force-pushed
the
improve-thread-safety
branch
4 times, most recently
from
f4942ea to
3a1f19d
Compare
madsmtm
force-pushed
the
improve-thread-safety
branch
from
3a1f19d to
a8daf53
Compare
daxpedda
reviewed
Aug 7, 2023
|
I'd need this on Wayland as well if it matters, but not due to thread safety reasons. I'll try to post a patch for what I need once I have time... |
kchibisov
force-pushed
the
improve-thread-safety
branch
from
e6b1751 to
ddc1d6b
Compare
kchibisov
approved these changes
Aug 14, 2023
This was referenced Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve thread safety on macOS and iOS.
@daxpedda: This is using a generic mechanism that unifies it with the web backend - I think it's the right way forward, although it might be slightly less efficient (since it has to do the main thread check a bit more often).
Part of #2464.
CHANGELOG.mdif knowledge of this change could be valuable to users