Make iOS fully thread safe #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
S - enhancement
madsmtm
force-pushed
the
finish-apple-thread-safety
branch
from
f94bde1 to
e0fb1cf
Compare
madsmtm
force-pushed
the
finish-apple-thread-safety
branch
from
e0fb1cf to
e73b3a3
Compare
|
CI fails installing |
|
@madsmtm it's just broken cargo, don't think about it. |
|
I've fixed it already thoug.h |
|
Looks like a transitive dependency that bumped their MSRV eagerly. |
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
* macOS & iOS: Refactor EventWrapper * macOS & iOS: Make EventLoopWindowTarget independent of the user event * iOS: Use MainThreadMarker instead of marking functions unsafe * Make iOS thread safe
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
* macOS & iOS: Refactor EventWrapper * macOS & iOS: Make EventLoopWindowTarget independent of the user event * iOS: Use MainThreadMarker instead of marking functions unsafe * Make iOS thread safe
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2464.
Now,
MonitorHandleandVideoModeare usable from any thread.Also did a few other cleanups, in preparation for making
EventLoopWindowTargetindependent of the user event type, to fix the macOS and iOS part of #3053.CHANGELOG.mdif knowledge of this change could be valuable to users