Fix reset to Poll
after the event loop starts
#3107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3056 introduced the possibility of setting
ControlFlow
before the event loop starts. This was not taken into account before #3056, therefore some code existed that assumed that it always starts withControlFlow::Poll
.This PR corrects or removes these assumption and fixes the bug that
ControlFlow
is always reset toPoll
after the event loop starts. As a side effect,ControlFlow
is also not reset toPoll
after pump events & co.I also moved some of the
set_control_flow()
calls in examples and documentation up toEventLoop
instead of having to call them insiderun()
onEventLoopWindowTarget
.Discovered in #3106.