Remove WindowBuilder
in favour of WindowAttributes
#3400
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #3318.
Rough draft, the plan is to move towards:
I think in this case it makes sense to remove the builder, because it really is just attributes; but in a case like
EventLoopBuilder
, I think it still makes sense to keep that as a builder.CHANGELOG.md
if knowledge of this change could be valuable to users