-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split dpi
module out into a separate crate
#3518
Conversation
f01dfc4
to
fd08dcd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is exactly what I was looking for. I will do a small PR for the single unit types afterwards.
@@ -0,0 +1,39 @@ | |||
[package] | |||
name = "dpi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the point to name it dpi and not winit-dpi
, since it's tailored towards the dpi needs of winit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly because the name dpi
was free, but also because the crate isn't really fundamentally tied to Winit.
Co-authored-by: John Nunley <[email protected]>
Part of #3433.
This PR is mostly about the documentation update, the actual API changes that Tauri needs can be done in subsequent PRs.
CHANGELOG.md
if knowledge of this change could be valuable to usersCC @amrbashir