Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split dpi module out into a separate crate #3518

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Split dpi module out into a separate crate #3518

merged 3 commits into from
Feb 26, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Feb 23, 2024

Part of #3433.

This PR is mostly about the documentation update, the actual API changes that Tauri needs can be done in subsequent PRs.

  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior

CC @amrbashir

@madsmtm madsmtm added the S - maintenance Repaying technical debt label Feb 23, 2024
@madsmtm madsmtm force-pushed the dpi branch 2 times, most recently from f01dfc4 to fd08dcd Compare February 23, 2024 17:41
Copy link
Contributor

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is exactly what I was looking for. I will do a small PR for the single unit types afterwards.

@@ -0,0 +1,39 @@
[package]
name = "dpi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the point to name it dpi and not winit-dpi, since it's tailored towards the dpi needs of winit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly because the name dpi was free, but also because the crate isn't really fundamentally tied to Winit.

dpi/Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@madsmtm madsmtm merged commit e41f0ea into master Feb 26, 2024
51 checks passed
@madsmtm madsmtm deleted the dpi branch February 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S - maintenance Repaying technical debt
Development

Successfully merging this pull request may close these issues.

6 participants