x11: fix WindowAttributesExtX11::with_x11_screen(), extend example
#3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2024
strohel
added a commit
to tonarino/winit
that referenced
this pull request
Oct 31, 2024
Based on rust-windowing#3973, which should be merged first. There's an API to programmatically specify X11 screen id (override what is determined from the `DISPLAY` env variable), but it doesn't work. Seeting up X Server with 2 screens and calling `DISPLAY=:0 X11_SCREEN_ID=1 cargo run --example window` should be equivalent to calling `DISPLAY=:0.1 cargo run --example window` The latter works (and places the window on the correct screen), but the former yields `failed to create initial window: Os(OsError { line: 620, file: "src/platform_impl/linux/x11/window.rs", error: X11Error(X11Error { error_kind: Match, error_code: 8, sequence: 219, bad_value: 1319, minor_opcode: 0, major_opcode: 1, extension_name: None, request_name: Some("CreateWindow") }) })` _Here `1319` is the root window id for screen 0, which doesn't match the screen 1 that we request._ The problem is that we need to factor in the screen id when determining the parent (root) window when not explicitly set. This patch does that.
strohel
force-pushed
the
fix-with-x11-screen
branch
from
b8d2c97 to
bef697f
Compare
|
Gentle ping if I can get your review @notgull / @kchibisov 🙏. I've also rebased this on latest |
|
Could you please squash your commits into one as per CONTRIBUTING.md? |
Based on rust-windowing#3973, which should be merged first. There's an API to programmatically specify X11 screen id (override what is determined from the `DISPLAY` env variable), but it doesn't work. Seeting up X Server with 2 screens and calling `DISPLAY=:0 X11_SCREEN_ID=1 cargo run --example window` should be equivalent to calling `DISPLAY=:0.1 cargo run --example window` The latter works (and places the window on the correct screen), but the former yields `failed to create initial window: Os(OsError { line: 620, file: "src/platform_impl/linux/x11/window.rs", error: X11Error(X11Error { error_kind: Match, error_code: 8, sequence: 219, bad_value: 1319, minor_opcode: 0, major_opcode: 1, extension_name: None, request_name: Some("CreateWindow") }) })` _Here `1319` is the root window id for screen 0, which doesn't match the screen 1 that we request._ The problem is that we need to factor in the screen id when determining the parent (root) window when not explicitly set. This patch does that. --- Also: Extend the window example with X11_{SCREEN,VISUAL}_ID env variables
strohel
force-pushed
the
fix-with-x11-screen
branch
from
bef697f to
f2be80e
Compare
Sure, pushed! |
|
(belated) Thanks for merging!
|
|
I'll see what I can do with patch release once I have time, unless someone else won't do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a kind of follow-up to #3973.
There's an API to programmatically specify X11 screen id (override what is determined from the
DISPLAYenv variable), but it doesn't work.Setting up X Server with 2 screens and calling
DISPLAY=:0 X11_SCREEN_ID=1 cargo run --example windowshould be equivalent to callingDISPLAY=:0.1 cargo run --example windowThe latter works now (and places the window on the correct screen), but the former yields
failed to create initial window: Os(OsError { line: 620, file: "src/platform_impl/linux/x11/window.rs", error: X11Error(X11Error { error_kind: Match, error_code: 8, sequence: 219, bad_value: 1319, minor_opcode: 0, major_opcode: 1, extension_name: None, request_name: Some("CreateWindow") }) })Here
1319is the root window id for screen 0, which doesn't match the screen 1 that we request.The problem is that we need to factor in the screen id when determining the parent (root) window when not explicitly set. This patch does that.
CC @bschwind @mbernat.
There is also a soft-prerequisite commit that extends the
windowexample to make the code change more easily testable. I've done the simplest possible thing and accept the optional parameters as env variables. Let me know if that's fine.changelogmodule if knowledge of this change could be valuable to usersUpdated documentation to reflect any user-facing changes, including notes of platform-specific behaviorUpdated feature matrix, if new features were added or implemented