Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to wlr_layer_shell #4044

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SergioRibera
Copy link

@SergioRibera SergioRibera commented Dec 18, 2024

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

Yup, this is another PR trying to integrate layer_shell support to winit, personally I use this feature a lot and even considered making my own windowing system to support this feature, but that would be counterproductive to the ecosystem and I prefer to add this feature so the rest can enjoy it.

My main goal is to try to preserve as much as possible the interaction with the default API, to some extent I think it is a success but there are things that can not be avoided to change.

Clearly and as you will notice this PR is strongly inspired by #2832 I decided to make another one due to the low activity on the original author's github instead of contacting him and contributing to his fork.

Fixes #2582

Unresolved design questions:

  • I would imagine Anchor, KeyboardInteractivity, and Layer should be reexported in winit::platform::wayland
  • Additionally this also gives us the possibility to do other cool things in wayland like moving the window at will or getting the position of the window (here we probably have to debate whether storing the position is wise).

@SergioRibera SergioRibera changed the title Support to wlr_layer_shell (YET another PR, 2024 updated) Support to wlr_layer_shell Dec 18, 2024
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response is the same as for other PRs, not unless backend split is done, which I hope should be soon.

@SergioRibera
Copy link
Author

The response is the same as for other PRs, not unless backend split is done, which I hope should be soon.

Well, it seems completely make sense to me, is there any site where they are discussing this topic? I will leave the PR open for now and keep it updated with respect to the main winit branch.

@kchibisov
Copy link
Member

Everything you need is present on github issues here and opened PRs. You can subscribe to #3433 .

@SergioRibera
Copy link
Author

Perfect, thank you, I also joined the matrix server that you have in the README, I will be in contact to help you with whatever you need 🦀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Support for Wayland's wlr-layer-shell protocol
2 participants