Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about using custom WebDrivers #2867

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Conversation

thisisrandy
Copy link
Contributor

@thisisrandy thisisrandy commented Apr 15, 2022

This updates the docs to reflect the change made in rustwasm/wasm-pack#1127 and discussed in rustwasm/wasm-pack#1126.

@alexcrichton alexcrichton merged commit 8ac33c6 into rustwasm:main Apr 18, 2022
@thisisrandy
Copy link
Contributor Author

@alexcrichton this change actually isn't accurate until rustwasm/wasm-pack#1127 is merged. Could you take a look at that as well please?

@alexcrichton
Copy link
Contributor

Ah ok, I will revert this. I don't manage wasm-pack though.

alexcrichton added a commit that referenced this pull request Apr 19, 2022
@thisisrandy
Copy link
Contributor Author

I see. I saw your fingerprints on something over there and assumed, but I see now that I was mistaken. How would you prefer I handle this? It's a bit awkward to have two contingent PRs to different repos pending.

@alexcrichton
Copy link
Contributor

Sorry but I don't help out with wasm-pack any more so I don't know how to coordinate the two repos.

@thisisrandy
Copy link
Contributor Author

Okay then. I think what I'll do is wait for the wasm-pack PR to be resolved (it's been quite some time at this point, but hopefully someone looks at it eventually), and then resubmit this PR to update the docs. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants