Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to 2018 edition and update dependencies #1048

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

fkettelhoit
Copy link
Contributor

This PR migrates to the 2018 edition and updates all dependencies in a way that no duplicate dependencies are pulled in, which resolves the issues #798 and #801.

Before the PR:

$ cargo tree --duplicates | wc -l
398

After:

$ cargo tree --duplicates | wc -l
0

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@fkettelhoit fkettelhoit marked this pull request as draft August 7, 2021 12:59
@fkettelhoit fkettelhoit marked this pull request as ready for review August 7, 2021 13:16
@drager
Copy link
Member

drager commented Aug 31, 2021

@fkettelhoit Thanks a lot! I will go through this more closely in a while, I think this will be released in v0.11.0. Feel free to rebase master into your branch when you got time 😊

@drager drager added this to the 0.11.0 milestone Sep 5, 2021
@bytesnail
Copy link

Migrate to edition 2021 may be another choice

@saks
Copy link

saks commented Sep 9, 2022

Any help needed with this?

@drager drager removed this from the 0.11.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants