Add sidekiq 7.2 to test matrix #22
Conversation
rwojsznis
force-pushed
the
sidekiq-7.2-support
branch
from
5f069a6 to
a62ac87
Compare
|
In case anyone is waiting for this - not forgotten, just got busy with everyday work; will try to keep this gem alive :) |
|
Awesome, thanks |
|
I def use this gem on like every project btw, so you know your work is awesome. It solves a really important need that for some reason isnt just built into sidekiq. |
|
|
||
| # very not fancy (https://78.media.tumblr.com/tumblr_lzkpw7DAl21qhy6c9o2_400.gif) | ||
| # solution, but should do the job | ||
| Open3.popen3(cmd) do |stdin, stdout, stderr, thread| | ||
| begin | ||
| Timeout.timeout(5) do | ||
| Timeout.timeout(3) do |
There was a problem hiding this comment.
still no better idea for this one, leaving as it
| @@ -1,3 +1,4 @@ | |||
| $LOAD_PATH.unshift(File.expand_path('../lib', __dir__)) | |||
There was a problem hiding this comment.
not sure how this worked before; seems like something changed with load paths I'm not aware of? require stopped working 🤔 will not investigate if the build is green tho 🙈
| spec.add_development_dependency "bundler" | ||
| spec.add_development_dependency "rake" | ||
| spec.add_development_dependency "mocha", "~> 0.14.0" | ||
| spec.add_development_dependency "minitest" | ||
| spec.add_development_dependency "appraisal" |
There was a problem hiding this comment.
unsure what's the best practice nowadays, seems like sidekiq itself defines all this stuff in Gemfile now
|
All tests green; will release new version this week; dropped sidekiq 5 from the matrix as it seems EOLed? |
Initial discovery on #21
Root cause: https://github.com/sidekiq/sidekiq/blob/main/Changes.md#720
7.2 changed their internal API regarding calling
redis-client; Support to 7.0 was added by community in #18 and I have very vague memory of it